This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104417/

On March 30th, 2012, 8:18 p.m., Thomas Lübking wrote:

service/jobs/nepomuk/Move.cpp (Diff revision 5)
bool Move::canMove(const QUrl & source)
352
    if (source.scheme() != QLatin1String("file")) {
"!QUrl::isLocalFile()"?

On March 30th, 2012, 8:40 p.m., Lamarque Vieira Souza wrote:

isLocalFile() was introduced in Qt 4.8.0 and we still use Qt 4.7.4 in Meego image.

On March 30th, 2012, 8:45 p.m., Thomas Lübking wrote:

Qt doc bogus?
http://qt-project.org/doc/qt-4.8/qurl.html#isLocalFile
Yes: http://qt-project.org/doc/note_revisions/137/234/view

- Lamarque Vieira


On March 30th, 2012, 6:57 p.m., Lamarque Vieira Souza wrote:

Review request for KDE Runtime and Plasma.
By Lamarque Vieira Souza.

Updated March 30, 2012, 6:57 p.m.

Description

When adding an application resource to a private activity kactivitymanager tries to move the resource's .desktop file to the activity's private folder. The new .desktop file is created successfully but the source file is not deleted if the user does not have write permission on the file's directory. This patch detects such situation and uses copy instead of move to prevent "permission denied" messages for every resource being added.

Testing

Works for resources of type "app", it does not work for "image" yet because Move::canMove receives the nepomuk's uri instead of the file url when the resource type is "image".
Bugs: 296808

Diffs

  • service/jobs/nepomuk/Move.h (8a8afd1)
  • service/jobs/nepomuk/Move.cpp (2248768)

View Diff