--===============3001435559118717990== Content-Type: multipart/alternative; boundary="===============8381561754153087214==" --===============8381561754153087214== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104422/#review11968 ----------------------------------------------------------- This review has been submitted with commit c5a16ec2b64da98991f67dcd991c33ab= c3888c5c by Rick Stockton to branch KDE/4.8. - Commit Hook On March 27, 2012, 5:26 a.m., Richard Stockton wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104422/ > ----------------------------------------------------------- > = > (Updated March 27, 2012, 5:26 a.m.) > = > = > Review request for Plasma and Martin Gr=C3=A4=C3=9Flin. > = > = > Description > ------- > = > Kickoff needs a way to enter the "All Applications" Tab, using only the k= eyboard. > = > With this patch, pressing 'Qt::Key_Up' or 'Qt::Key_Down' will leave the '= Launcher' and enter the "Applications" View content area, when the "Applica= tions" icon is highlighted in the tab bar. From inside the "All Application= s" Widget, the User may press Qt::Key_Tab to return to the Launcher (for sw= itching to another tab, or for performing a search.) Qt::Key_Tab must gener= ally be pressed TWICE. > = > This makes entry into the "Applications" tab, and exit back to the Launch= er, the same as the other tabs (i.e., "Favorites", "Recently Used", "Comput= er", and "Leave"). This is a patch only for 4.8, because widget-based Kicko= ff will be replaced with a QML launcher in KDE 4.9. > = > = > This addresses bugs 276932 and 296696. > http://bugs.kde.org/show_bug.cgi?id=3D276932 > http://bugs.kde.org/show_bug.cgi?id=3D296696 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 = > = > Diff: http://git.reviewboard.kde.org/r/104422/diff/ > = > = > Testing > ------- > = > compiled, tested, and using in production. > = > Note for testers: There is one bit of weirdness, not new, and it's the sa= me with all of the Other Tabs: From inside the tab's content area, you must= make TWO KeyPress events of Qt::Key_Tab in order to highlight the search b= ar TextEdit Widget properly. I don't know exactly "where" focus goes after = the first Tab keyPressEvent, when neither the content area nor the search T= extEdit are highlighted. (And I'm not going to waste time figuring it out, = because this all gets replaced with 4.9.) > = > = > Thanks, > = > Richard Stockton > = > --===============8381561754153087214== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104422/ 

This revie=
w has been submitted with commit c5a16ec2b64da98991f67dcd991c33abc3888c5c b=
y Rick Stockton to branch KDE/4.8.

- Commit


On March 27th, 2012, 5:26 a.m., Richard Stockton wrote:

Review request for Plasma and Martin Gr=C3=A4=C3=9Flin.
By Richard Stockton.

Updated March 27, 2012, 5:26 a.m.

Descripti= on 

Kickoff needs a way to enter the "All Applications"=
; Tab, using only the keyboard.

With this patch, pressing 'Qt::Key_Up' or 'Qt::Key_Down' wi=
ll leave the 'Launcher' and enter the "Applications" View=
 content area, when the "Applications" icon is highlighted in the=
 tab bar. From inside the "All Applications" Widget, the User may=
 press Qt::Key_Tab to return to the Launcher (for switching to another tab,=
 or for performing a search.) Qt::Key_Tab must generally be pressed TWICE.

This makes entry into the "Applications" tab, and exit back to th=
e Launcher, the same as the other tabs (i.e., "Favorites", "=
Recently Used", "Computer", and "Leave"). This is =
a patch only for 4.8, because widget-based Kickoff will be replaced with a =
QML launcher in KDE 4.9.

Testing <= /h1> 
compiled, tested, and using in production.

Note for testers: There is one bit of weirdness, not new, and it's the =
same with all of the Other Tabs: From inside the tab's content area, yo=
u must make TWO KeyPress events of Qt::Key_Tab in order to highlight the se=
arch bar TextEdit Widget properly. I don't know exactly "where&quo=
t; focus goes after the first Tab keyPressEvent, when neither the content a=
rea nor the search TextEdit are highlighted. (And I'm not going to wast=
e time figuring it out, because this all gets replaced with 4.9.)
Bugs: 276932, = 296696

Diffs=

  • plasma/desktop/applets/kickoff/ui/launcher.cpp (3662ef0)

View Diff
--===============8381561754153087214==-- --===============3001435559118717990== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3001435559118717990==--