[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Copy files instead of moving if parent dir is not writable
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-03-27 9:56:03
Message-ID: 20120327095603.29910.91008 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104417/#review11899
-----------------------------------------------------------
Excuse my naivity here, but how does this make sense? If a user asks to make certain \
data private, he expects them to be not available in unencrypted fashion anymore. \
Copying to the encrypted folder doesn't solve this, as the file is still available \
unencrypted, at its previous location.
The user would think his data is protected, while it isn't -> not good.
Or am I missing something here?
- Sebastian Kügler
On March 26, 2012, 6:04 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104417/
> -----------------------------------------------------------
>
> (Updated March 26, 2012, 6:04 p.m.)
>
>
> Review request for KDE Runtime and Plasma.
>
>
> Description
> -------
>
> When adding an application resource to a private activity kactivitymanager tries to \
> move the resource's .desktop file to the activity's private folder. The new \
> .desktop file is created successfully but the source file is not deleted if the \
> user does not have write permission on the file's directory. This patch detects \
> such situation and uses copy instead of move to prevent "permission denied" \
> messages for every resource being added.
>
> This addresses bug 296808.
> http://bugs.kde.org/show_bug.cgi?id=296808
>
>
> Diffs
> -----
>
> service/jobs/nepomuk/Move.h 8a8afd1
> service/jobs/nepomuk/Move.cpp 08a3cc2
>
> Diff: http://git.reviewboard.kde.org/r/104417/diff/
>
>
> Testing
> -------
>
> Works on Meego devel image. The file is copied and no error message is shown.
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104417/">http://git.reviewboard.kde.org/r/104417/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Excuse my naivity here, \
but how does this make sense? If a user asks to make certain data private, he expects \
them to be not available in unencrypted fashion anymore. Copying to the encrypted \
folder doesn't solve this, as the file is still available unencrypted, at its \
previous location.
The user would think his data is protected, while it isn't -> not good.
Or am I missing something here?</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On March 26th, 2012, 6:04 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Plasma.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated March 26, 2012, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When adding an application resource to a private activity \
kactivitymanager tries to move the resource's .desktop file to the activity's \
private folder. The new .desktop file is created successfully but the source file is \
not deleted if the user does not have write permission on the file's directory. \
This patch detects such situation and uses copy instead of move to prevent \
"permission denied" messages for every resource being added.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works on Meego devel image. The file is copied and no error message is \
shown.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=296808">296808</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>service/jobs/nepomuk/Move.h <span style="color: grey">(8a8afd1)</span></li>
<li>service/jobs/nepomuk/Move.cpp <span style="color: grey">(08a3cc2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104417/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic