'Re: Review Request: [RFC]: Rename "Configure Window Behavior" to "Window Manager Settings"'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: [RFC]: Rename "Configure Window Behavior" to "Window Manager Settings"
From:       "Commit Hook" <null () kde ! org>
Date:       2012-03-25 11:01:43
Message-ID: 20120325110143.27465.14268 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104284/#review11832
-----------------------------------------------------------

This review has been submitted with commit 828791505ee8fb38abf407d7a999fc07b07b62e5 \
by Martin Gräßlin to branch master.

- Commit Hook

On March 22, 2012, 5:59 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104284/
> -----------------------------------------------------------
> 
> (Updated March 22, 2012, 5:59 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Adding Plasma to get general feedback on this idea.
> 
> The context menu entry to "Configure Window Behavior" opens the
> configuration of the window manager and not about the window.
> In the past the shown configuration dialog only contained entries
> affecting the window behavior but that is no longer true for the
> complete KDE 4.x series since Desktop Effects had been added to
> the menu. This change in naming reflects the situation and should
> help to remove confusion.
> 
> 
> This addresses bug 249486.
> http://bugs.kde.org/show_bug.cgi?id=249486
> 
> 
> Diffs
> -----
> 
> kwin/useractions.cpp dfb6fd4 
> 
> Diff: http://git.reviewboard.kde.org/r/104284/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104284/">http://git.reviewboard.kde.org/r/104284/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 828791505ee8fb38abf407d7a999fc07b07b62e5 by Martin Gräßlin to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On March 22nd, 2012, 5:59 a.m., Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated March 22, 2012, 5:59 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding Plasma to get general feedback on this idea.

The context menu entry to &quot;Configure Window Behavior&quot; opens the
configuration of the window manager and not about the window.
In the past the shown configuration dialog only contained entries
affecting the window behavior but that is no longer true for the
complete KDE 4.x series since Desktop Effects had been added to
the menu. This change in naming reflects the situation and should
help to remove confusion.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=249486">249486</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104284/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 