[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Synchronise useractions menu with taskmanager
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-25 11:01:44
Message-ID: 20120325110144.27467.950 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104374/#review11833
-----------------------------------------------------------
This review has been submitted with commit 43ab5b781e901558feb63dfee90ca5175a280c98 by Martin Gräßlin to branch master.
- Commit Hook
On March 23, 2012, 7:11 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104374/
> -----------------------------------------------------------
>
> (Updated March 23, 2012, 7:11 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Changes the order of the useractions menu to fit the one of
> taskmanager. There are still some differences:
> * Taskmanager is missing Activities menu
> * Taskmanager is missing Window Tabbing support
> * Taskmanager is missing window settings (e.g. shortcut)
> * Useractions is missing launcher support
>
> I don't think it is possible to add the missing support to Taskmanager at the moment.
>
>
> This addresses bug 296056.
> http://bugs.kde.org/show_bug.cgi?id=296056
>
>
> Diffs
> -----
>
> kwin/useractions.cpp dfb6fd4
> libs/taskmanager/taskactions.cpp e6f9c26
>
> Diff: http://git.reviewboard.kde.org/r/104374/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104374/">http://git.reviewboard.kde.org/r/104374/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit \
43ab5b781e901558feb63dfee90ca5175a280c98 by Martin Gräßlin to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 23rd, 2012, 7:11 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 7:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes the order of the useractions menu to \
fit the one of taskmanager. There are still some differences:
* Taskmanager is missing Activities menu
* Taskmanager is missing Window Tabbing support
* Taskmanager is missing window settings (e.g. shortcut)
* Useractions is missing launcher support
I don't think it is possible to add the missing support to Taskmanager at the moment.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=296056">296056</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/useractions.cpp <span style="color: grey">(dfb6fd4)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: grey">(e6f9c26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104374/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic