From kde-panel-devel Sun Mar 25 02:59:35 2012 From: "Viranch Mehta" Date: Sun, 25 Mar 2012 02:59:35 +0000 To: kde-panel-devel Subject: Review Request: Couple of fixes to QML ScrollBar component Message-Id: <20120325025935.2463.56513 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=133264445802527 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8262969925591750534==" --===============8262969925591750534== Content-Type: multipart/alternative; boundary="===============8715864714063988998==" --===============8715864714063988998== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104402/ ----------------------------------------------------------- Review request for Plasma. Description ------- This patch fixes following issues with QML Scrollbar component: - The hover and non-hover arrow images in vertical scrollbars are the same. - The down/right arrows are connected to events of mousearea of up/left arr= ows. - The mouseareas of the arrows do not have hoverEnabled property set to tru= e. This is required to use their containsMouse property. Diffs ----- plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelegate.= qml 15ee7aa = Diff: http://git.reviewboard.kde.org/r/104402/diff/ Testing ------- I didn't know how to test these from Gallery.qml (what command?). Tested, h= owever, by putting in a test plasmoid. Works well now. Thanks, Viranch Mehta --===============8715864714063988998== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104402/

Review request for Plasma.

By Viranch Mehta.

Descripti= on

This patch fixes following issues with QML Scrollbar compone=
nt:

- The hover and non-hover arrow images in vertical scrollbars are the same.
- The down/right arrows are connected to events of mousearea of up/left arr=
ows.
- The mouseareas of the arrows do not have hoverEnabled property set to tru=
e. This is required to use their containsMouse property.

Testing <= /h1>

I didn't know how to test these from Gallery.qml (what c=
ommand?). Tested, however, by putting in a test plasmoid. Works well now.

Diffs=

plasma/declarativeimports/plasmacomponents/qml/private/ScrollBarDelega= te.qml (15ee7aa)

View Diff

--===============8715864714063988998==-- --===============8262969925591750534== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8262969925591750534==--

Descripti= on

Testing <= /h1> I didn't know how to test these from Gallery.qml (what c= ommand?). Tested, however, by putting in a test plasmoid. Works well now.

Diffs=

Testing <= /h1>

I didn't know how to test these from Gallery.qml (what c= ommand?). Tested, however, by putting in a test plasmoid. Works well now.