[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Scroll automatically when touching the border with the rubberband
From: "Commit Hook" <null () kde ! org>
Date: 2012-03-24 16:24:16
Message-ID: 20120324162416.3066.28356 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104396/#review11811
-----------------------------------------------------------
This review has been submitted with commit 8d3055fb4a0455b7f01deae5801b4ba8f67abf3e \
by Ignat Semenov to branch master.
- Commit Hook
On March 24, 2012, 12:42 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104396/
> -----------------------------------------------------------
>
> (Updated March 24, 2012, 12:42 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.
>
>
> Description
> -------
>
> Wehn dragging a rubberband over an icon view with a scrollbar, scroll the view \
> automatically on touching the border with the mouse during drag.
> I've had to mod stopAutoScrolling() and call it in IconView::wheelEvent() and \
> AbstractItemView::scrollBarActionTriggered() to allow the user to stop the \
> automatic scrolling on those events.
>
> This addresses bug 189350.
> http://bugs.kde.org/show_bug.cgi?id=189350
>
>
> Diffs
> -----
>
> plasma/applets/folderview/abstractitemview.cpp 3debb70
> plasma/applets/folderview/iconview.h 0bd6dc0
> plasma/applets/folderview/iconview.cpp 36e640b
>
> Diff: http://git.reviewboard.kde.org/r/104396/diff/
>
>
> Testing
> -------
>
> Tested, works.
>
> Maybe we should also stop automatic scrolling if the user releases the LMB while \
> scrollling automatically as a result of dragging the rubberband over the view \
> border? Fredrik, what do you think?
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104396/">http://git.reviewboard.kde.org/r/104396/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8d3055fb4a0455b7f01deae5801b4ba8f67abf3e by Ignat Semenov to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On March 24th, 2012, 12:42 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Fredrik Höglund.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated March 24, 2012, 12:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wehn dragging a rubberband over an icon view with a scrollbar, scroll \
the view automatically on touching the border with the mouse during drag.
I've had to mod stopAutoScrolling() and call it in IconView::wheelEvent() and \
AbstractItemView::scrollBarActionTriggered() to allow the user to stop the automatic \
scrolling on those events.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.
Maybe we should also stop automatic scrolling if the user releases the LMB while \
scrollling automatically as a result of dragging the rubberband over the view border? \
Fredrik, what do you think?</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=189350">189350</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/abstractitemview.cpp <span style="color: \
grey">(3debb70)</span></li>
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(0bd6dc0)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(36e640b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104396/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic