'Re: Review Request: Add a link to the current desktop folder instead of an'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add a link to the current desktop folder instead of an
From:       "Ignat Semenov" <13thguards () gmail ! com>
Date:       2012-03-20 17:05:16
Message-ID: 20120320170516.21172.94619 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103830/
-----------------------------------------------------------

(Updated March 20, 2012, 5:05 p.m.)

Review request for Plasma and Aaron J. Seigo.

Changes
-------

addUrl(KUrl) -> addUrls(const KUrl::List&)

ReviewBoard and multiple git repos for different parts of kde is not the mo=
st comfortable thing to use, though..

Description
-------

Currently, right-clicking a Kickoff/Classical application launcher entry an=
d selectiong "Add to Desktop" puts an icon applet on the desktop. However, =
if the desktop is set to Folderview, it is more consistent to add a link to=
 the currently displayed folder. This patch cheks if the "folderview" plugi=
n is used in the desktop containment and performs a KIO::link() if that's t=
he case.

Diffs (updated)
-----

  plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 99c2649 =

Diff: http://git.reviewboard.kde.org/r/103830/diff/

Testing
-------

Tested, works.

Thanks,

Ignat Semenov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103830/">http://git.reviewboard.kde.org/r/103830/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Ignat Semenov.</div>

<p style="color: grey;"><i>Updated March 20, 2012, 5:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">addUrl(KUrl) -&gt; addUrls(const KUrl::List&amp;)

ReviewBoard and multiple git repos for different parts of kde is not the most \
comfortable thing to use, though..</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, right-clicking a Kickoff/Classical application launcher entry \
and selectiong &quot;Add to Desktop&quot; puts an icon applet on the desktop. \
However, if the desktop is set to Folderview, it is more consistent to add a link to \
the currently displayed folder. This patch cheks if the &quot;folderview&quot; plugin \
is used in the desktop containment and performs a KIO::link() if that&#39;s the \
case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <span style="color: \
grey">(99c2649)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103830/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 