'Re: Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by d'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by d
From:       Fredrik_Höglund <fredrik () kde ! org>
Date:       2012-03-17 14:19:47
Message-ID: 20120317141947.15099.14578 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104311/#review11504
-----------------------------------------------------------

Ship it!

Ship It!

- Fredrik H=C3=B6glund

On March 17, 2012, 9:52 a.m., Ignat Semenov wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104311/
> -----------------------------------------------------------
> =

> (Updated March 17, 2012, 9:52 a.m.)
> =

> =

> Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik H=C3=
=B6glund.
> =

> =

> Description
> -------
> =

> Do not call setUrl in the ctor since m_dirLister does not exist yet. Inst=
ead, assign m_url in the ctor and call setUrl later in init().
> =

> =

> Diffs
> -----
> =

>   plasma/applets/folderview/folderview.cpp a94ce87 =

> =

> Diff: http://git.reviewboard.kde.org/r/104311/diff/
> =

> =

> Testing
> -------
> =

> Tested, works.
> =

> Would be nice to give the code a static analyzer run, if there was a dece=
nt static analyzer available in Linux. Anybody have relevant experience?
> =

> =

> Thanks,
> =

> Ignat Semenov
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104311/">http://git.reviewboard.kde.org/r/104311/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Fredrik</p>

<br />
<p>On March 17th, 2012, 9:52 a.m., Ignat Semenov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik \
Höglund.</div> <div>By Ignat Semenov.</div>

<p style="color: grey;"><i>Updated March 17, 2012, 9:52 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Do not call setUrl in the ctor since m_dirLister does not exist yet. \
Instead, assign m_url in the ctor and call setUrl later in init().</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.

Would be nice to give the code a static analyzer run, if there was a decent static \
analyzer available in Linux. Anybody have relevant experience?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(a94ce87)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104311/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 