[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Save scrollbar position on plasma exit
From: "Ignat Semenov" <13thguards () gmail ! com>
Date: 2012-03-17 9:48:57
Message-ID: 20120317094857.25606.13669 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 13, 2012, 1:12 p.m., Marco Martin wrote:
> > looks good, a thing i would like to be tested is when the saved position is \
> > invalid, like either negative or an enormous value.
> > this shouldn't break it (is even quite probable a value not being valid anymore \
> > because there are less files than the previous session)
>
> Fredrik Höglund wrote:
> I think it would be a good idea to save the modification time for the folder and \
> use that to check if the saved scrollbar value is likely to be invalid. If the user \
> is able to scroll the view while the layout is in progress, this should also abort \
> restoring the position.
> Also, I'm wondering if we really need to save the position separately for the \
> iconview and the listview, or if we should use the same key.
> Otherwise the patch looks good to me.
>
> Ignat Semenov wrote:
> Well I've been thinking about separate vs single key and I think separate is easier \
> to read and maintain, less checks and branches.
> The main problem with a single key would be when the applet is put into a panel, \
> first the icon view gets created and grabs the value, then the list view gets \
> created and gets a 0. Two keys are easier to work with I think.
> As for scrolling when the layout is in progress, this method is intended to be used \
> at startup only, so the user can not scroll the view. Or do you mean that some dev \
> could use restoreScrollbarPosition() manually after startup?
> Folder mtime is a nice idea, one more corner case, will try to implement.
>
> Ignat Semenov wrote:
> Actually, aborting the automatic scrolling works just fine, as \
> smoothScroll(savedPosition) is used and that one can be interrupted easily.
> Ignat Semenov wrote:
> OK, as discussed with fredrikh on IRC yesterday, the patch now accounts for \
> multiple layout passes. As far as the dir mtime issue goes, I think that actually \
> falls into the range check case, that is, if the dir content changes, but the \
> number of rows does not, it's probably ok to restore the scroll position. If the \
> number of rows changes, then the scrollbar range changes and that is caught by the \
> check in scrollToSavedPosition(). Same for the list view.
> Now the only relevant issue is actually aborting the restore if scrolling the view \
> between layout passes in a slow dir.
OK, the only thing left now is to correctly handle this:
applet created on the desktop -> scrolled -> put into the panel ->url changed -> \
dragged back to the desktop -> scrolled again, but the dir is different and the \
scroll is invalid
on the other hand, we can't simply discard the value after restoring the position, \
since if the above is done without changing the url, the scrollbar restore on panel \
-> desktop is desired and correct.
- Ignat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104258/#review11354
-----------------------------------------------------------
On March 16, 2012, 4:31 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104258/
> -----------------------------------------------------------
>
> (Updated March 16, 2012, 4:31 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund.
>
>
> Description
> -------
>
> This patch implements scrolbar position saving on plasma exit. The change is fairly \
> trivial, however, due to the fact that the view is not populated and layouted \
> immediately simply scrolling to the desired position on creating the view does not \
> work. Instead a signal is emitted on finishing the item layout, when the view has a \
> valid size and the scrollbar has a valid range. The signal is connected to a slot \
> which scrolls the view to the desired position and then disconnects the signal. For \
> the user, a public function in AbstractItemView is introduced, which performs the \
> connection.
> The only problem is that ListView turned out not to have any layout method. It just \
> paints the items one by one, calculating their position on the fly, so I put the \
> signal at the end of updateScrollbar to ensure the scrollbar range is valid. Maybe \
> it should go into the "if (max>0)" branch?
>
> This addresses bug 261139.
> http://bugs.kde.org/show_bug.cgi?id=261139
>
>
> Diffs
> -----
>
> plasma/applets/folderview/abstractitemview.h aa68b90
> plasma/applets/folderview/abstractitemview.cpp 3debb70
> plasma/applets/folderview/folderview.h 4e441eb
> plasma/applets/folderview/folderview.cpp a94ce87
> plasma/applets/folderview/iconview.h 12e93b3
> plasma/applets/folderview/iconview.cpp 5c4e086
> plasma/applets/folderview/listview.cpp 94efe44
>
> Diff: http://git.reviewboard.kde.org/r/104258/diff/
>
>
> Testing
> -------
>
> Tested both the icon view and the list view, works fine.
>
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104258/">http://git.reviewboard.kde.org/r/104258/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 13th, 2012, 1:12 p.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good, a thing i would like to be tested is when the saved position \
is invalid, like either negative or an enormous value.
this shouldn't break it (is even quite probable a value not being valid anymore \
because there are less files than the previous session)</pre> </blockquote>
<p>On March 13th, 2012, 1:55 p.m., <b>Fredrik Höglund</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it would be a \
good idea to save the modification time for the folder and use that to check if the \
saved scrollbar value is likely to be invalid. If the user is able to scroll the view \
while the layout is in progress, this should also abort restoring the position.
Also, I'm wondering if we really need to save the position separately for the \
iconview and the listview, or if we should use the same key.
Otherwise the patch looks good to me.</pre>
</blockquote>
<p>On March 13th, 2012, 1:59 p.m., <b>Ignat Semenov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well I've been \
thinking about separate vs single key and I think separate is easier to read and \
maintain, less checks and branches.
The main problem with a single key would be when the applet is put into a panel, \
first the icon view gets created and grabs the value, then the list view gets created \
and gets a 0. Two keys are easier to work with I think.
As for scrolling when the layout is in progress, this method is intended to be used \
at startup only, so the user can not scroll the view. Or do you mean that some dev \
could use restoreScrollbarPosition() manually after startup?
Folder mtime is a nice idea, one more corner case, will try to implement.</pre>
</blockquote>
<p>On March 13th, 2012, 5:26 p.m., <b>Ignat Semenov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, aborting the \
automatic scrolling works just fine, as smoothScroll(savedPosition) is used and that \
one can be interrupted easily.</pre> </blockquote>
<p>On March 14th, 2012, 10:38 a.m., <b>Ignat Semenov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, as discussed with \
fredrikh on IRC yesterday, the patch now accounts for multiple layout passes. As far \
as the dir mtime issue goes, I think that actually falls into the range check case, \
that is, if the dir content changes, but the number of rows does not, it's \
probably ok to restore the scroll position. If the number of rows changes, then the \
scrollbar range changes and that is caught by the check in scrollToSavedPosition(). \
Same for the list view.
Now the only relevant issue is actually aborting the restore if scrolling the view \
between layout passes in a slow dir.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, the only thing left \
now is to correctly handle this:
applet created on the desktop -> scrolled -> put into the panel ->url \
changed -> dragged back to the desktop -> scrolled again, but the dir is \
different and the scroll is invalid
on the other hand, we can't simply discard the value after restoring the \
position, since if the above is done without changing the url, the scrollbar restore \
on panel -> desktop is desired and correct.</pre> <br />
<p>- Ignat</p>
<br />
<p>On March 16th, 2012, 4:31 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik \
Höglund.</div> <div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated March 16, 2012, 4:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements scrolbar position saving on plasma exit. The \
change is fairly trivial, however, due to the fact that the view is not populated and \
layouted immediately simply scrolling to the desired position on creating the view \
does not work. Instead a signal is emitted on finishing the item layout, when the \
view has a valid size and the scrollbar has a valid range. The signal is connected to \
a slot which scrolls the view to the desired position and then disconnects the \
signal. For the user, a public function in AbstractItemView is introduced, which \
performs the connection.
The only problem is that ListView turned out not to have any layout method. It just \
paints the items one by one, calculating their position on the fly, so I put the \
signal at the end of updateScrollbar to ensure the scrollbar range is valid. Maybe it \
should go into the "if (max>0)" branch?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested both the icon view and the list view, works fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=261139">261139</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/abstractitemview.h <span style="color: \
grey">(aa68b90)</span></li>
<li>plasma/applets/folderview/abstractitemview.cpp <span style="color: \
grey">(3debb70)</span></li>
<li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(4e441eb)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(a94ce87)</span></li>
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(12e93b3)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(5c4e086)</span></li>
<li>plasma/applets/folderview/listview.cpp <span style="color: \
grey">(94efe44)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104258/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic