[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add a link to the current desktop folder instead of an
From: "Ignat Semenov" <13thguards () gmail ! com>
Date: 2012-03-02 15:15:49
Message-ID: 20120302151549.14657.91881 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 1, 2012, 11:35 a.m., Aaron J. Seigo wrote:
> > i really don't like this change because it puts in a hardcoded assumpti=
on about folderview into an independent component. is folderview the only a=
pplet/containment that should behave this way? probably not. what if we rep=
lace folderview someday with something else? is kickoff the only place from=
which you can add an item to a folderview? =
> > =
> > it's just not generic enough, and that "no assumptions" approach is som=
ething that we stick to in plasma which allows us to easily pull components=
out, replace them with others, etc. we already have this solved when there=
is a drag and drop event: each applet handles its own drop events and does=
what is necessary.
> > =
> > on the other hand, i also don't want to see an "addUrl" type method to =
Applet since that is going to be irrelevant to the vast majority of Applets=
and itself contains some assumptions.
> > =
> > this calls for a better solution that can be implemented in the target =
Applet and which doesn't result in assumptions about what the source or tar=
gets are.
OK how about if we commit this for 4.8.1 and provide the 100% correct fix i=
n master and 4.8.2?
- Ignat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103830/#review10265
-----------------------------------------------------------
On Jan. 31, 2012, 3:45 p.m., Ignat Semenov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103830/
> -----------------------------------------------------------
> =
> (Updated Jan. 31, 2012, 3:45 p.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> Currently, right-clicking a Kickoff/Classical application launcher entry =
and selectiong "Add to Desktop" puts an icon applet on the desktop. However=
, if the desktop is set to Folderview, it is more consistent to add a link =
to the currently displayed folder. This patch cheks if the "folderview" plu=
gin is used in the desktop containment and performs a KIO::link() if that's=
the case.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 8db9655 =
> =
> Diff: http://git.reviewboard.kde.org/r/103830/diff/
> =
> =
> Testing
> -------
> =
> Tested, works.
> =
> =
> Thanks,
> =
> Ignat Semenov
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103830/">http://git.reviewboard.kde.org/r/103830/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 1st, 2012, 11:35 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i really don't like this change because it puts in a hardcoded \
assumption about folderview into an independent component. is folderview the only \
applet/containment that should behave this way? probably not. what if we replace \
folderview someday with something else? is kickoff the only place from which you can \
add an item to a folderview?
it's just not generic enough, and that "no assumptions" approach is \
something that we stick to in plasma which allows us to easily pull components out, \
replace them with others, etc. we already have this solved when there is a drag and \
drop event: each applet handles its own drop events and does what is necessary.
on the other hand, i also don't want to see an "addUrl" type method to \
Applet since that is going to be irrelevant to the vast majority of Applets and \
itself contains some assumptions.
this calls for a better solution that can be implemented in the target Applet and \
which doesn't result in assumptions about what the source or targets are.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK how about if we \
commit this for 4.8.1 and provide the 100% correct fix in master and 4.8.2?</pre> <br \
/>
<p>- Ignat</p>
<br />
<p>On January 31st, 2012, 3:45 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2012, 3:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, right-clicking a Kickoff/Classical application launcher entry \
and selectiong "Add to Desktop" puts an icon applet on the desktop. \
However, if the desktop is set to Folderview, it is more consistent to add a link to \
the currently displayed folder. This patch cheks if the "folderview" plugin \
is used in the desktop containment and performs a KIO::link() if that's the \
case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <span style="color: \
grey">(8db9655)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103830/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic