--===============2658877173012516130== Content-Type: multipart/alternative; boundary="===============5837430381204908443==" --===============5837430381204908443== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104086/ ----------------------------------------------------------- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description ------- When I try in the plasma desktop console the algorithm that calculate the b= iggestId in systray-to-notifications-widget.js, it gives me a wrong result = for biggestId and biggestId+1. The real biggestId in my plasma-desktop-appletsrc is 82 ([Containments][76]= [Applets][82]). The current algorithm gives me: print(biggestId) -> 5 print(biggestId+1) -> 51 print(typeof(biggestId)) -> string because in for (var j in activity.widgetIds) { if (j > biggestId) { biggestId =3D j } j is the key (string key) of the array activity.widgetIds. The suggested patch gives the good result. regards, Luc Menut - Mageia PS: I don't have write access to kde git, so could you commit the change fo= r me if the patch looks fine. Thanks. Diffs ----- plasma/desktop/shell/configupdates/systray-to-notifications-widget.js 7a3= 1de6 = Diff: http://git.reviewboard.kde.org/r/104086/diff/ Testing ------- tested with KDE 4.8.0 (Mageia Cauldron) Thanks, Luc Menut --===============5837430381204908443== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104086/

Review request for Plasma, Aaron J. Seigo and Marco Martin.
By Luc Menut.

Descripti= on 

When I try in the plasma desktop console the algorithm that =
calculate the biggestId in systray-to-notifications-widget.js, it gives me =
a wrong result for biggestId and biggestId+1.
The real biggestId in my plasma-desktop-appletsrc is 82 ([Containments][76]=
[Applets][82]).
The current algorithm gives me:
print(biggestId)          -> 5
print(biggestId+1)        -> 51
print(typeof(biggestId))  -> string

because in
for (var j in activity.widgetIds) {
  if (j > biggestId) {
    biggestId =3D j
}
j is the key (string key) of the array activity.widgetIds.

The suggested patch gives the good result.


regards,
Luc Menut - Mageia

PS: I don't have write access to kde git, so could you commit the chang=
e for me if the patch looks fine. Thanks.

Testing <= /h1> 
tested with KDE 4.8.0 (Mageia Cauldron)

Diffs=

  • plasma/desktop/shell/configupdates/systray-to-notifications-widget.js = (7a31de6)

View Diff
--===============5837430381204908443==-- --===============2658877173012516130== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2658877173012516130==--