'Re: Review Request: Improve the QML RunnerModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Improve the QML RunnerModel
From:       "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date:       2012-02-11 11:41:37
Message-ID: 20120211114137.30986.60512 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103806/
-----------------------------------------------------------

(Updated Feb. 11, 2012, 11:41 a.m.)

Review request for Plasma.

Changes
-------

Hey Aaron! You were right, those two last methods I added them because I wa=
nted to make the plugin configure stuff but I ended up doing it in a differ=
ent way, actually using the KPluginSelector which will have to be implement=
ed in QtQuick eventually.

I removed all the QObject expositions I had, I hope you're all happy now ;).

Description
-------

Adds some features to the RunnerModel so that it can be used properly in th=
e KRunner QML implementation I've been working on (see the testing section).

Also it simplifies the code a bit by moving from QAbstractItemModel -> QAbs=
tractListModel.

Diffs (updated)
-----

  components/runnermodel/runnermodel.h 899bf1f =

  components/runnermodel/runnermodel.cpp a226f8e =

Diff: http://git.reviewboard.kde.org/r/103806/diff/diff

Testing
-------

use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner impl=
emented in QtQuick).

here's a video, so that you know what's going on: http://www.proli.net/meu/=
netrunner/qmlrunner.ogv

Thanks,

Aleix Pol Gonzalez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103806/">http://git.reviewboard.kde.org/r/103806/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Feb. 11, 2012, 11:41 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hey Aaron! You were right, those two last methods I added them because I \
wanted to make the plugin configure stuff but I ended up doing it in a different way, \
actually using the KPluginSelector which will have to be implemented in QtQuick \
eventually.

I removed all the QObject expositions I had, I hope you&#39;re all happy now \
;).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds some features to the RunnerModel so that it can be used properly in \
the KRunner QML implementation I&#39;ve been working on (see the testing section).

Also it simplifies the code a bit by moving from QAbstractItemModel -&gt; \
QAbstractListModel.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner \
implemented in QtQuick).

here&#39;s a video, so that you know what&#39;s going on: \
http://www.proli.net/meu/netrunner/qmlrunner.ogv</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>components/runnermodel/runnermodel.h <span style="color: \
grey">(899bf1f)</span></li>

 <li>components/runnermodel/runnermodel.cpp <span style="color: \
grey">(a226f8e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103806/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 