[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix folderview sorting
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-09 18:50:39
Message-ID: 20120209185039.4114.45227 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103895/#review10466
-----------------------------------------------------------
This review has been submitted with commit ec55520721b71820bb4f928bf35f58f9=
b339ed14 by Ignat Semenov to branch KDE/4.8.
- Commit Hook
On Feb. 9, 2012, 6:22 p.m., Ignat Semenov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103895/
> -----------------------------------------------------------
> =
> (Updated Feb. 9, 2012, 6:22 p.m.)
> =
> =
> Review request for Plasma, Aaron J. Seigo, Marco Martin, Peter Penz, and =
Fredrik H=C3=B6glund.
> =
> =
> Description
> -------
> =
> This patch fixes the inconsistent sorting issues in FolderView.
> =
> 1)It introduces explicit support for sorting by size. Prior to the change=
, sorting by Size was done as follows:convert the size into a string and us=
e KStringHandler::naturalCompare(). Of course, this is not the same as a pr=
oper int comparison - FW sorted incorrectly by size.
> 2)Introduce one important concept:fallback to comparing the name if the m=
ain sorting column is not enough to determine a sort order. This is especia=
lly important for sorting by type - sorting by size needs this as well, but=
different files are way less likely to have the same size compared to the =
possibility of them having similar types.
> 3)Intoduce full three-level fallback for ensuring file name uniqueness, t=
aken from Dolphin code. Thanks a bunch goes to Peter Penz :)
> 4)And of course, sort folders by the child count if sorting by size. Agai=
n, Dolphin inspired.
> =
> =
> Diffs
> -----
> =
> plasma/applets/folderview/proxymodel.cpp 4b3340e =
> =
> Diff: http://git.reviewboard.kde.org/r/103895/diff/diff
> =
> =
> Testing
> -------
> =
> Tested, yields results similar to Dolphin sorting of the same folder (sur=
pise! :) ).
> =
> =
> Thanks,
> =
> Ignat Semenov
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103895/">http://git.reviewboard.kde.org/r/103895/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit ec55520721b71820bb4f928bf35f58f9b339ed14 by Ignat Semenov to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 9th, 2012, 6:22 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Marco Martin, Peter Penz, and Fredrik \
Höglund.</div> <div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Feb. 9, 2012, 6:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes the inconsistent sorting issues in FolderView.
1)It introduces explicit support for sorting by size. Prior to the change, sorting by \
Size was done as follows:convert the size into a string and use \
KStringHandler::naturalCompare(). Of course, this is not the same as a proper int \
comparison - FW sorted incorrectly by size. 2)Introduce one important \
concept:fallback to comparing the name if the main sorting column is not enough to \
determine a sort order. This is especially important for sorting by type - sorting by \
size needs this as well, but different files are way less likely to have the same \
size compared to the possibility of them having similar types. 3)Intoduce full \
three-level fallback for ensuring file name uniqueness, taken from Dolphin code. \
Thanks a bunch goes to Peter Penz :) 4)And of course, sort folders by the child count \
if sorting by size. Again, Dolphin inspired.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, yields results similar to Dolphin sorting of the same folder \
(surpise! :) ).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/proxymodel.cpp <span style="color: \
grey">(4b3340e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103895/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic