'Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview
From:       "Ignat Semenov" <13thguards () gmail ! com>
Date:       2012-02-03 18:55:14
Message-ID: 20120203185514.29923.54222 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103860/
-----------------------------------------------------------

(Updated Feb. 3, 2012, 6:55 p.m.)

Review request for Plasma, Aaron J. Seigo and Marco Martin.

Changes
-------

Strings to ints.

Description
-------

This patch allows to select between acsending and descending icon sort order in \
folderview.

THe QVariant() and the short-circuit if's in cg.readEntry() / cg.writeEntry() stem \
from the fact that Qt::SortOrder can not be converted to an int, and needs to be \
operated this way. Thanks go to dfaure for explaining me how to do deal with the enum \
problem.

This addresses bug 180646.
    http://bugs.kde.org/show_bug.cgi?id=180646

Diffs (updated)
-----

  plasma/applets/folderview/folderview.h e458d77 
  plasma/applets/folderview/folderview.cpp 54ea14a 

Diff: http://git.reviewboard.kde.org/r/103860/diff/diff

Testing
-------

Tested, works. Changes the icon sort direction, even though the actual sorting is \
sometimes broken (my next task, most probably.)

Thanks,

Ignat Semenov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103860/">http://git.reviewboard.kde.org/r/103860/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>

<p style="color: grey;"><i>Updated Feb. 3, 2012, 6:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Strings to ints.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch allows to select between acsending and descending icon sort \
order in folderview.

THe QVariant() and the short-circuit if&#39;s in cg.readEntry() / cg.writeEntry() \
stem from the fact that Qt::SortOrder can not be converted to an int, and needs to be \
operated this way. Thanks go to dfaure for explaining me how to do deal with the enum \
problem.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works. Changes the icon sort direction, even though the actual \
sorting is sometimes broken (my next task, most probably.)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=180646">180646</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(e458d77)</span></li>

 <li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(54ea14a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103860/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 