[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Apply the IconView model settings to the PopupView in the PopupView constructor
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-03 11:15:35
Message-ID: 20120203111535.28454.30049 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103851/#review10313
-----------------------------------------------------------
This review has been submitted with commit 539b48c396b904d993caeefffa264b9aaa6a480e \
by Ignat Semenov to branch KDE/4.8.
- Commit Hook
On Feb. 2, 2012, 6:44 p.m., Ignat Semenov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103851/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2012, 6:44 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
>
>
> Description
> -------
>
> Apply the necessary model settings to the ProxyModel object in \
> PopupView::PopupView(...) identically to the FolderView::init() method. This fixes \
> bug 211002.
>
> This addresses bug 211002.
> http://bugs.kde.org/show_bug.cgi?id=211002
>
>
> Diffs
> -----
>
> plasma/applets/folderview/popupview.h 0243b2f
> plasma/applets/folderview/popupview.cpp 7fdb3f7
>
> Diff: http://git.reviewboard.kde.org/r/103851/diff/diff
>
>
> Testing
> -------
>
> Tested, works.
>
>
> Thanks,
>
> Ignat Semenov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103851/">http://git.reviewboard.kde.org/r/103851/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 539b48c396b904d993caeefffa264b9aaa6a480e by Ignat Semenov to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 2nd, 2012, 6:44 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2012, 6:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Apply the necessary model settings to the ProxyModel object in \
PopupView::PopupView(...) identically to the FolderView::init() method. This fixes \
bug 211002.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=211002">211002</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/popupview.h <span style="color: \
grey">(0243b2f)</span></li>
<li>plasma/applets/folderview/popupview.cpp <span style="color: \
grey">(7fdb3f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103851/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic