[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView ap
From: "Commit Hook" <null () kde ! org>
Date: 2012-02-01 13:21:45
Message-ID: 20120201132145.20543.49346 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103618/#review10268
-----------------------------------------------------------
This review has been submitted with commit d6293cad6468a24c5e3292a61207d065=
8ff21306 by Ignat Semenov to branch KDE/4.8.
- Commit Hook
On Jan. 3, 2012, 5:21 p.m., Ignat Semenov wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103618/
> -----------------------------------------------------------
> =
> (Updated Jan. 3, 2012, 5:21 p.m.)
> =
> =
> Review request for Plasma, Aaron J. Seigo and Peter Penz.
> =
> =
> Description
> -------
> =
> This patch implements a proposal from the Netrunner project (netrunner-os=
.com), a KUbuntu derivative, aimed at polishing the KDE desktop, as part of=
my work for the project.
> =
> This feature allows the user to hide the "+" selection marker in the Fold=
erView applet. It is absolutely symmetrical to the "Click to view folder" f=
eature. The code is similar as well. One thing I had to change is the butto=
n hiding logic in ActionOverlay. The selection marker is positioned above t=
he folder peek button, so it needs a QGraphicsGridLayout::removeItem() / ::=
addItem() instead of a QWidget::hide(), performed every time on the entered=
() event. As the ::removeItem() has to be called only once, I had to implem=
ent a public function that would toggle the button hiding / unhiding.
> =
> Then, to be symmetrical, I changed the folder peek button hiding code to =
use the same functions, with the same public interface in the ActionAoverla=
y class.
> =
> I hope the function addition is OK and does not violate neither incapsult=
ion nor the KDE class design principles.
> =
> =
> Diffs
> -----
> =
> plasma/applets/folderview/actionoverlay.h 056c83b =
> plasma/applets/folderview/actionoverlay.cpp 430e6dc =
> plasma/applets/folderview/folderview.h c8869b4 =
> plasma/applets/folderview/folderview.cpp d620a7d =
> plasma/applets/folderview/iconview.h 677aa76 =
> plasma/applets/folderview/iconview.cpp abf775e =
> =
> Diff: http://git.reviewboard.kde.org/r/103618/diff/diff
> =
> =
> Testing
> -------
> =
> Works fine.
> =
> The only problem is that following a recent Aaron's commit regarding conf=
igChanged() / configAccepeted() in the FolderView applet circa 2 weeks ago,=
the settings in this applet are applied only on Plasma restart and not on =
the fly after hitting the Appy or Ok buttons. Aaron, please, have a look in=
to this. This happens with any settings, not onyl the ones I added. (My set=
tings code is absolutely identical to the "Click to view folder" settigns c=
ode).
> =
> =
> Thanks,
> =
> Ignat Semenov
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103618/">http://git.reviewboard.kde.org/r/103618/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d6293cad6468a24c5e3292a61207d0658ff21306 by Ignat Semenov to \
branch KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 3rd, 2012, 5:21 p.m., Ignat Semenov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Peter Penz.</div>
<div>By Ignat Semenov.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2012, 5:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements a proposal from the Netrunner project \
(netrunner-os.com), a KUbuntu derivative, aimed at polishing the KDE desktop, as part \
of my work for the project.
This feature allows the user to hide the "+" selection marker in the \
FolderView applet. It is absolutely symmetrical to the "Click to view \
folder" feature. The code is similar as well. One thing I had to change is the \
button hiding logic in ActionOverlay. The selection marker is positioned above the \
folder peek button, so it needs a QGraphicsGridLayout::removeItem() / ::addItem() \
instead of a QWidget::hide(), performed every time on the entered() event. As the \
::removeItem() has to be called only once, I had to implement a public function that \
would toggle the button hiding / unhiding.
Then, to be symmetrical, I changed the folder peek button hiding code to use the same \
functions, with the same public interface in the ActionAoverlay class.
I hope the function addition is OK and does not violate neither incapsultion nor the \
KDE class design principles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine.
The only problem is that following a recent Aaron's commit regarding \
configChanged() / configAccepeted() in the FolderView applet circa 2 weeks ago, the \
settings in this applet are applied only on Plasma restart and not on the fly after \
hitting the Appy or Ok buttons. Aaron, please, have a look into this. This happens \
with any settings, not onyl the ones I added. (My settings code is absolutely \
identical to the "Click to view folder" settigns code).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/actionoverlay.h <span style="color: \
grey">(056c83b)</span></li>
<li>plasma/applets/folderview/actionoverlay.cpp <span style="color: \
grey">(430e6dc)</span></li>
<li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(c8869b4)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(d620a7d)</span></li>
<li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(677aa76)</span></li>
<li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(abf775e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103618/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic