'Re: Review Request: Fix the double-click icon shrink issue in the FolderView applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix the double-click icon shrink issue in the FolderView applet
From:       "Commit Hook" <null () kde ! org>
Date:       2012-02-01 13:21:43
Message-ID: 20120201132143.20511.35859 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103679/#review10267
-----------------------------------------------------------

This review has been submitted with commit 08999c8a4c9851c56e112be42c4ade21=
148a4846 by Ignat Semenov to branch KDE/4.8.

- Commit Hook

On Jan. 13, 2012, 2:11 p.m., Ignat Semenov wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103679/
> -----------------------------------------------------------
> =

> (Updated Jan. 13, 2012, 2:11 p.m.)
> =

> =

> Review request for Plasma and Aaron J. Seigo.
> =

> =

> Description
> -------
> =

> With KDE set to double-click, the icons in the FolderView applet would sh=
rink twice on double-licking them. This is a visual glitch. The patch addre=
sses that, shrinking the icon on the mouseDoubleClicked() event instead of =
the mousePressed() event if KDE is set to duble-click.
> =

> =

> Diffs
> -----
> =

>   plasma/applets/folderview/iconview.cpp d295588 =

> =

> Diff: http://git.reviewboard.kde.org/r/103679/diff/diff
> =

> =

> Testing
> -------
> =

> Tested, works both with KDe set ot single- and double-click.
> =

> =

> Thanks,
> =

> Ignat Semenov
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103679/">http://git.reviewboard.kde.org/r/103679/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 08999c8a4c9851c56e112be42c4ade21148a4846 by Ignat Semenov to \
branch KDE/4.8.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 13th, 2012, 2:11 p.m., Ignat Semenov wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Ignat Semenov.</div>

<p style="color: grey;"><i>Updated Jan. 13, 2012, 2:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With KDE set to double-click, the icons in the FolderView applet would \
shrink twice on double-licking them. This is a visual glitch. The patch addresses \
that, shrinking the icon on the mouseDoubleClicked() event instead of the \
mousePressed() event if KDE is set to duble-click.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested, works both with KDe set ot single- and double-click.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/iconview.cpp <span style="color: \
grey">(d295588)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103679/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 