'Review Request: Fix incorrect painting of Plasma::IconWidget on double-click with KDE set to double-'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Fix incorrect painting of Plasma::IconWidget on double-click with KDE set to double-
From:       "Ignat Semenov" <13thguards () gmail ! com>
Date:       2012-01-31 16:41:14
Message-ID: 20120131164114.17891.37320 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103831/
-----------------------------------------------------------

Review request for Plasma, Aaron J. Seigo and Marco Martin.

Description
-------

Same as https://git.reviewboard.kde.org/r/103679/, but for the Plasma::Icon=
Widget. Let the icon shrink on the double-click event, ignoring single-clic=
ks, if KDE is set to double-click. Also take in account the corner case whe=
n the IconWidget lives in a panel and thus reacts to the clicked() signal.

Diffs
-----

  plasma/widgets/iconwidget.cpp 1161cc4 =

Diff: http://git.reviewboard.kde.org/r/103831/diff/diff

Testing
-------

Tested on desktop and in the panel with KDE set to both double- and single-=
click, works fine.

Thanks,

Ignat Semenov

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103831/">http://git.reviewboard.kde.org/r/103831/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Ignat Semenov.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Same as https://git.reviewboard.kde.org/r/103679/, but for the \
Plasma::IconWidget. Let the icon shrink on the double-click event, ignoring \
single-clicks, if KDE is set to double-click. Also take in account the corner case \
when the IconWidget lives in a panel and thus reacts to the clicked() signal.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on desktop and in the panel with KDE set to both double- and \
single-click, works fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/widgets/iconwidget.cpp <span style="color: grey">(1161cc4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103831/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 