[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: make UNC path work in krunner by mapping it to smb:// path
From: "Martin Koller" <kollix () aon ! at>
Date: 2012-01-30 7:54:34
Message-ID: 20120130075434.31990.14848 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 29, 2012, 10:54 p.m., Mark Gaiser wrote:
> > Now that's a lot easier right ;-) Note: i found that out the hard way \
> > as well. Just look at my first revision : \
> > https://svn.reviewboard.kde.org/r/5284/diff/1/#index_header
> -)
Yes, you're absolutely right. I didn't know that class before.
Thanks for the hint!!
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103826/#review10214
-----------------------------------------------------------
On Jan. 29, 2012, 10:15 p.m., Martin Koller wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103826/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2012, 10:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> revive the possibility to enter an UNC path e.g. \\hostname\some\path \
> into krunner leading to an smb://hostname/some/path target as is done in \
> konqueror's address bar.
>
> This addresses bug 211317.
> http://bugs.kde.org/show_bug.cgi?id=211317
>
>
> Diffs
> -----
>
> plasma/generic/runners/locations/locationrunner.cpp c8ec8ae
>
> Diff: http://git.reviewboard.kde.org/r/103826/diff/diff
>
>
> Testing
> -------
>
> Tested local paths, # and ## shortcuts (man and info), tar: zip: special \
> protocols, \\ and \\host\path style URL, $HOME/bin
>
> Thanks,
>
> Martin Koller
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103826/">http://git.reviewboard.kde.org/r/103826/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On January 29th, 2012, \
10:54 p.m., <b>Mark Gaiser</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Now that's \
a lot easier right ;-) Note: i found that out the hard way as well. Just \
look at my first revision : \
https://svn.reviewboard.kde.org/r/5284/diff/1/#index_header</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:-) Yes, \
you're absolutely right. I didn't know that class before. Thanks \
for the hint!!</pre> <br />
<p>- Martin</p>
<br />
<p>On January 29th, 2012, 10:15 p.m., Martin Koller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2012, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">revive the possibility to enter an UNC path e.g. \
\\hostname\some\path into krunner leading to an smb://hostname/some/path \
target as is done in konqueror's address bar.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested local paths, # and ## shortcuts (man and info), tar: \
zip: special protocols, \\ and \\host\path style URL, $HOME/bin</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=211317">211317</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/runners/locations/locationrunner.cpp <span \
style="color: grey">(c8ec8ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103826/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic