'Re: Review Request: make UNC path work in krunner by mapping it to smb:// path'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: make UNC path work in krunner by mapping it to smb:// path
From:       "Mark Gaiser" <markg85 () gmail ! com>
Date:       2012-01-29 19:49:39
Message-ID: 20120129194939.24951.65833 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103826/#review10209
-----------------------------------------------------------

Why don't you use KUriFilter for that? I happen to made a patch for that some time \
ago so that it would also translate \\ to smb:/. Take a look at my patch back then: \
https://svn.reviewboard.kde.org/r/5284/diff/#index_header

What you need is just "kshorturifilter" which does what you want (among a bunch of \
other things).

- Mark Gaiser

On Jan. 29, 2012, 7:05 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103826/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 7:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> revive the possibility to enter an UNC path e.g. \\hostname\some\path into krunner \
> leading to an smb://hostname/some/path target as is done in konqueror's address \
> bar. 
> 
> This addresses bug 211317.
> http://bugs.kde.org/show_bug.cgi?id=211317
> 
> 
> Diffs
> -----
> 
> plasma/generic/runners/locations/locationrunner.cpp c8ec8ae 
> 
> Diff: http://git.reviewboard.kde.org/r/103826/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Koller
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103826/">http://git.reviewboard.kde.org/r/103826/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why don&#39;t you use \
KUriFilter for that? I happen to made a patch for that some time ago so that it would \
also translate \\ to smb:/. Take a look at my patch back then: \
https://svn.reviewboard.kde.org/r/5284/diff/#index_header

What you need is just &quot;kshorturifilter&quot; which does what you want (among a \
bunch of other things).</pre>  <br />

<p>- Mark</p>

<br />
<p>On January 29th, 2012, 7:05 p.m., Martin Koller wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Koller.</div>

<p style="color: grey;"><i>Updated Jan. 29, 2012, 7:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">revive the possibility to enter an UNC path e.g. \\hostname\some\path \
into krunner leading to an smb://hostname/some/path target as is done in \
konqueror&#39;s address bar.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=211317">211317</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/runners/locations/locationrunner.cpp <span style="color: \
grey">(c8ec8ae)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103826/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 