--===============3919633378724214518== Content-Type: multipart/alternative; boundary="===============0914374737590027509==" --===============0914374737590027509== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103685/ ----------------------------------------------------------- (Updated Jan. 29, 2012, 12:17 p.m.) Review request for Plasma and Aaron J. Seigo. Description ------- With the iconshrink patch, I introduced an issue with the icon text clippin= g. The thing is, the iconview items painting code is written in a way that = the text will accomodate fully only if the icon touches the top of the rect= r (iconview.cpp:1050), else the text will get clipped. TO achieve this eff= ect, Qt:AlignTop had been used. I changed that to Qt:AlignCenter and introd= uced the issue. This patch tries to locate the icon at the top border of the rect r (as it = had been before the commit), but when the icon shrinks, it moves towards it= s own center, same as the first commit. ir.moveTop(r.top()); Now when the icon is shrinked, it is moved down by half the difference betw= een its normal size and its shrinked size, which is perfectly logical. ir.translate(0, (m_drawIconShrinked && m_pressedIndex =3D=3D index) ? 0.05*= option.decorationSize.height() : 0); This centers the icon nicely around its own center. The text keeps "scaling= " towards the top as well, as it had been before the commit. In the idle st= ate, the text is accomodated fully, as it had been before the commit. Diffs ----- plasma/applets/folderview/iconview.cpp d295588 = Diff: http://git.reviewboard.kde.org/r/103685/diff/diff Testing ------- This is not final, there is 1 pixel offset bug in the halo drawing code. I'= m going to sleep today, this review request is just to show that I'm aware = that I have screwed things up and am working on getting the proper patch do= ne. Thanks, Ignat Semenov --===============0914374737590027509== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103685/

Review request for Plasma and Aaron J. Seigo.
By Ignat Semenov.

Updated Jan. 29, 2012, 12:17 p.m.

Descripti= on 

With the iconshrink patch, I introduced an issue with the ic=
on text clipping. The thing is, the iconview items painting code is written=
 in a way that the text will accomodate fully only if the icon touches the =
top of the rect r (iconview.cpp:1050), else the text will get clipped. TO a=
chieve this effect, Qt:AlignTop had been used. I changed that to Qt:AlignCe=
nter and introduced the issue.

This patch tries to locate the icon at the top border of the rect r (as it =
had been before the commit), but when the icon shrinks, it moves towards it=
s own center, same as the first commit.

ir.moveTop(r.top());

Now when the icon is shrinked, it is moved down by half the difference betw=
een its normal size and its shrinked size, which is perfectly logical.

ir.translate(0, (m_drawIconShrinked && m_pressedIndex =3D=3D index)=
 ? 0.05*option.decorationSize.height() : 0);

This centers the icon nicely around its own center. The text keeps "sc=
aling" towards the top as well, as it had been before the commit. In t=
he idle state, the text is accomodated fully, as it had been before the com=
mit.

Testing <= /h1> 
This is not final, there is 1 pixel offset bug in the halo d=
rawing code. I'm going to sleep today, this review request is just to s=
how that I'm aware that I have screwed things up and am working on gett=
ing the proper patch done.

Diffs=

  • plasma/applets/folderview/iconview.cpp (d2= 95588)

View Diff
--===============0914374737590027509==-- --===============3919633378724214518== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3919633378724214518==--