--===============7237424038680609436== Content-Type: multipart/alternative; boundary="===============3864344552513957317==" --===============3864344552513957317== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review10144 ----------------------------------------------------------- This review has been submitted with commit a4123b08c0cad1c559ec3ae76557acaa= f95b3f69 by Nikita Churaev to branch KDE/4.8. - Commit Hook On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103529/ > ----------------------------------------------------------- > = > (Updated Dec. 24, 2011, 5:35 p.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > Contrast bug: KGlobalSettings::contrast() returns different default value= than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color= control module uses contrast(), so when the user first uses color settings= , contrast appears to change. > = > Plasma popup bug: Right-aligned popups are one pixel away from right edge= of the screen and top-aligned popups (when panel is on top) are one pixel = inside panel. This is because the bug in QRect, where right() and bottom() = value return value that is less than the true value by one. This is a featu= re-bug that Qt developers aren't going to fix because of compatiability rea= sons. My patch just applies + 1 compensation to all expressions that use QR= ect::right() and QRect::bottom(). > = > = > Diffs > ----- > = > kdeui/kernel/kglobalsettings.cpp 819b314 = > plasma/corona.cpp 366a9df = > = > Diff: http://git.reviewboard.kde.org/r/103529/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > Nikita Churaev > = > --===============3864344552513957317== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103529/

This revie=
w has been submitted with commit a4123b08c0cad1c559ec3ae76557acaaf95b3f69 b=
y Nikita Churaev to branch KDE/4.8.

- Commit

On December 24th, 2011, 5:35 p.m., Nikita Churaev wrote:

Review request for kdelibs and Plasma.

By Nikita Churaev.

Updated Dec. 24, 2011, 5:35 p.m.

Descripti= on

Contrast bug: KGlobalSettings::contrast() returns different =
default value than KGlobalSettings::contrastF(). Oxygen uses contrastF() wh=
ile KDE color control module uses contrast(), so when the user first uses c=
olor settings, contrast appears to change.

Plasma popup bug: Right-aligned popups are one pixel away from right edge o=
f the screen and top-aligned popups (when panel is on top) are one pixel in=
side panel. This is because the bug in QRect, where right() and bottom() va=
lue return value that is less than the true value by one. This is a feature=
-bug that Qt developers aren't going to fix because of compatiability r=
easons. My patch just applies + 1 compensation to all expressions that use =
QRect::right() and QRect::bottom().

Diffs=

kdeui/kernel/kglobalsettings.cpp (819b314)=
plasma/corona.cpp (366a9df)

--===============3864344552513957317==-- --===============7237424038680609436== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7237424038680609436==--