This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/

This review has been submitted with commit a4123b08c0cad1c559ec3ae76557acaaf95b3f69 by Nikita Churaev to branch KDE/4.8.

- Commit


On December 24th, 2011, 5:35 p.m., Nikita Churaev wrote:

Review request for kdelibs and Plasma.
By Nikita Churaev.

Updated Dec. 24, 2011, 5:35 p.m.

Description

Contrast bug: KGlobalSettings::contrast() returns different default value than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color control module uses contrast(), so when the user first uses color settings, contrast appears to change.

Plasma popup bug: Right-aligned popups are one pixel away from right edge of the screen and top-aligned popups (when panel is on top) are one pixel inside panel. This is because the bug in QRect, where right() and bottom() value return value that is less than the true value by one. This is a feature-bug that Qt developers aren't going to fix because of compatiability reasons. My patch just applies + 1 compensation to all expressions that use QRect::right() and QRect::bottom().

Diffs

  • kdeui/kernel/kglobalsettings.cpp (819b314)
  • plasma/corona.cpp (366a9df)

View Diff