From kde-panel-devel Wed Jan 11 15:25:17 2012 From: "Commit Hook" Date: Wed, 11 Jan 2012 15:25:17 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix "Add to desktop" from Kickoff when you have several Message-Id: <20120111152517.22370.67337 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132629570114253 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1581037769245729982==" --===============1581037769245729982== Content-Type: multipart/alternative; boundary="===============6422421162746064071==" --===============6422421162746064071== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103645/#review9749 ----------------------------------------------------------- This review has been submitted with commit 105b03bec8be119380c8e7ff2f1a53ea= 38177cf0 by Anne-Marie Mahfouf to branch master. - Commit Hook On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103645/ > ----------------------------------------------------------- > = > (Updated Jan. 6, 2012, 9:11 p.m.) > = > = > Review request for Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > From Kickoff using "Add to desktop" when you have several virtual desktop= s and you enable "Different widgets for each desktop" in the pager settings= . KWindowSystem starts counting from 1 and Plasma from 0 > = > Without this fix "Add to desktop" adds to the next desktop or does not ad= d if you're on the last desktop. = > = > = > This addresses bug https://bugs.kde.org/show_bug.cgi?id=3D290368. > http://bugs.kde.org/show_bug.cgi?id=3Dhttps://bugs.kde.org/show_bug.c= gi?id=3D290368 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903 = > = > Diff: http://git.reviewboard.kde.org/r/103645/diff/diff > = > = > Testing > ------- > = > Local tests as thorough as I could do. > = > = > Thanks, > = > Anne-Marie Mahfouf > = > --===============6422421162746064071== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103645/ 

This revie=
w has been submitted with commit 105b03bec8be119380c8e7ff2f1a53ea38177cf0 b=
y Anne-Marie Mahfouf to branch master.

- Commit


On January 6th, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:

Review request for Plasma and Aaron J. Seigo.
By Anne-Marie Mahfouf.

Updated Jan. 6, 2012, 9:11 p.m.

Descripti= on 

From Kickoff using "Add to desktop" when you have =
several virtual desktops and you enable "Different widgets for each de=
sktop" in the pager settings. KWindowSystem starts counting from 1 and=
 Plasma from 0

Without this fix "Add to desktop" adds to the next desktop or doe=
s not add if you're on the last desktop.

Testing <= /h1> 
Local tests as thorough as I could do.

Diffs=

  • plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp (cf12903)

View Diff
--===============6422421162746064071==-- --===============1581037769245729982== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1581037769245729982==--