[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add little margin to widget explorer in dashboard view
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-01-11 12:51:45
Message-ID: 20120111125145.11150.51849 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103564/#review9742
-----------------------------------------------------------
Ship it!
other than getting rid of the magic value, looks good! switch this to use K=
Dialog::marginHint() and commit. thanks.
plasma/desktop/shell/dashboardview.cpp
<http://git.reviewboard.kde.org/r/103564/#comment8044>
where does the magic 13 come from? should probably be using the static =
int KDialog::marginHint() .. =
- Aaron J. Seigo
On Dec. 28, 2011, 12:56 p.m., Reza Shah wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103564/
> -----------------------------------------------------------
> =
> (Updated Dec. 28, 2011, 12:56 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> I have added little margin to widget explorer invoked from dashboard view.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/shell/dashboardview.cpp 0ac06ab =
> =
> Diff: http://git.reviewboard.kde.org/r/103564/diff/diff
> =
> =
> Testing
> -------
> =
> Tested against master, and seems worked well
> =
> =
> Screenshots
> -----------
> =
> widgetexplorer_in_dashboard
> http://git.reviewboard.kde.org/r/103564/s/385/
> =
> =
> Thanks,
> =
> Reza Shah
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103564/">http://git.reviewboard.kde.org/r/103564/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">other than getting rid \
of the magic value, looks good! switch this to use KDialog::marginHint() and commit. \
thanks.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103564/diff/1/?file=44981#file44981line213" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/shell/dashboardview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
DashboardView::showWidgetExplorer()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">213</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">widgetExplorer</span><span class="o">-></span><span \
class="n">layout</span><span class="p">()</span><span class="o">-></span><span \
class="n">setContentsMargins</span><span class="p">(</span><span \
class="mi">0</span><span class="p">,</span> <span class="mi">13</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">where does \
the magic 13 come from? should probably be using the static int KDialog::marginHint() \
.. </pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 28th, 2011, 12:56 p.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2011, 12:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have added little margin to widget explorer invoked from dashboard \
view.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested against master, and seems worked well</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/dashboardview.cpp <span style="color: \
grey">(0ac06ab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103564/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103564/s/385/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/28/dashboard_widget_explorer_400x100.png" \
style="border: 1px black solid;" alt="widgetexplorer_in_dashboard" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic