[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix "Add to desktop" from Kickoff when you have
From: Martin_Gräßlin <kde () martin-graesslin ! com>
Date: 2012-01-06 21:49:38
Message-ID: 20120106214938.21213.2146 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 6, 2012, 9:33 p.m., Martin Gräßlin wrote:
> > I just consulted the documentation and checked the properties on my system: that \
> > looks like KWindowSystem is wrong. The first desktop is 0. And further studies \
> > show that the bug might be in KWin. Will investigate further...
so just checked the relevant code in KWin and KWindowSystem: we start counting at 1 \
and just decrement/increment 1 when writing/reading the X property. Everything is \
fine with KWindowSystem reporting 1, the question is why Containment uses 0?
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103645/#review9628
-----------------------------------------------------------
On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103645/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2012, 9:11 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> From Kickoff using "Add to desktop" when you have several virtual desktops and you \
> enable "Different widgets for each desktop" in the pager settings. KWindowSystem \
> starts counting from 1 and Plasma from 0
> Without this fix "Add to desktop" adds to the next desktop or does not add if \
> you're on the last desktop.
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=290368.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903
>
> Diff: http://git.reviewboard.kde.org/r/103645/diff/diff
>
>
> Testing
> -------
>
> Local tests as thorough as I could do.
>
>
> Thanks,
>
> Anne-Marie Mahfouf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103645/">http://git.reviewboard.kde.org/r/103645/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 6th, 2012, 9:33 p.m., <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I just consulted the documentation and checked the properties on my \
system: that looks like KWindowSystem is wrong. The first desktop is 0. And further \
studies show that the bug might be in KWin. Will investigate further...</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">so just checked the \
relevant code in KWin and KWindowSystem: we start counting at 1 and just \
decrement/increment 1 when writing/reading the X property. Everything is fine with \
KWindowSystem reporting 1, the question is why Containment uses 0?</pre> <br />
<p>- Martin</p>
<br />
<p>On January 6th, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2012, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">From Kickoff using "Add to desktop" when you have several \
virtual desktops and you enable "Different widgets for each desktop" in the \
pager settings. KWindowSystem starts counting from 1 and Plasma from 0
Without this fix "Add to desktop" adds to the next desktop or does not add \
if you're on the last desktop. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Local tests as thorough as I could do.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368">https://bugs.kde.org/show_bug.cgi?id=290368</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp <span style="color: \
grey">(cf12903)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103645/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic