[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Fix bug
From: "Marco Martin" <notmart () gmail ! com>
Date: 2012-01-02 10:55:34
Message-ID: 20120102105534.21944.14970 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103597/#review9431
-----------------------------------------------------------
Ship it!
that's a very good catch ;)
yes, that's the way it's supposed to work.
qwidget level focus and qgraphicsscene level focus are two different beasts.
if there was another widget in that window besides the graphicsview (that i=
s one single widget, just as a qpushbutton or whatnot) the reason this happ=
ens becomes more evident.
i think this should go in 4.8
- Marco Martin
On Dec. 31, 2011, 7:27 a.m., Nikita Churaev wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103597/
> -----------------------------------------------------------
> =
> (Updated Dec. 31, 2011, 7:27 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> For some reason, QGraphicsView must be focused too for its children to re=
ceive events. This however looks hacky. Please explain why it works to me.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/shell/controllerwindow.cpp 6f3064f =
> =
> Diff: http://git.reviewboard.kde.org/r/103597/diff/diff
> =
> =
> Testing
> -------
> =
> Works as expected.
> =
> =
> Thanks,
> =
> Nikita Churaev
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103597/">http://git.reviewboard.kde.org/r/103597/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that's a very good \
catch ;) yes, that's the way it's supposed to work.
qwidget level focus and qgraphicsscene level focus are two different beasts.
if there was another widget in that window besides the graphicsview (that is one \
single widget, just as a qpushbutton or whatnot) the reason this happens becomes more \
evident.
i think this should go in 4.8</pre>
<br />
<p>- Marco</p>
<br />
<p>On December 31st, 2011, 7:27 a.m., Nikita Churaev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Nikita Churaev.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2011, 7:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason, QGraphicsView must be focused too for its children to \
receive events. This however looks hacky. Please explain why it works to me.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/controllerwindow.cpp <span style="color: \
grey">(6f3064f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103597/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic