--===============1829971137616281785== Content-Type: multipart/alternative; boundary="===============1251406629740706895==" --===============1251406629740706895== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/#review9302 ----------------------------------------------------------- This review has been submitted with commit 8bd86323cdbd11ffafb71b6d8f4836d0= d4339af3 by Lamarque V. Souza to branch KDE/4.8. - Commit Hook On Dec. 19, 2011, 2:03 p.m., Lamarque Vieira Souza wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103434/ > ----------------------------------------------------------- > = > (Updated Dec. 19, 2011, 2:03 p.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > The patch resets time format in digital clock plasmoid when the user chan= ges the 24h configuration in active-settings. > = > The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am= wondering if I should add this change to kdelibs instead of kde-workspace = to avoid duplicating code. Anyway, I wanted someone to review the code to s= ee if there can be any side effect. > = > = > This addresses bug 289094. > http://bugs.kde.org/show_bug.cgi?id=3D289094 > = > = > Diffs > ----- > = > plasma/generic/applets/digital-clock/clock.h 4aec3fd = > plasma/generic/applets/digital-clock/clock.cpp dd03692 = > = > Diff: http://git.reviewboard.kde.org/r/103434/diff/diff > = > = > Testing > ------- > = > Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobal= Settings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does n= ot take effect. Other kcm modules (e.g. keyboard), call emitChange. > = > = > Thanks, > = > Lamarque Vieira Souza > = > --===============1251406629740706895== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103434/

This revie=
w has been submitted with commit 8bd86323cdbd11ffafb71b6d8f4836d0d4339af3 b=
y Lamarque V. Souza to branch KDE/4.8.

- Commit

On December 19th, 2011, 2:03 p.m., Lamarque Vieira Souza wrote:

Review request for kdelibs and Plasma.

By Lamarque Vieira Souza.

Updated Dec. 19, 2011, 2:03 p.m.

Descripti= on

The patch resets time format in digital clock plasmoid when =
the user changes the 24h configuration in active-settings.

The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am w=
ondering if I should add this change to kdelibs instead of kde-workspace to=
 avoid duplicating code. Anyway, I wanted someone to review the code to see=
 if there can be any side effect.

Testing <= /h1>

Works in Plasma Active. In Plasma Desktop kcmlocale does not=
 call KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChang=
ed) so it does not take effect. Other kcm modules (e.g. keyboard), call emi=
tChange.

Bugs: 289094

Diffs=

plasma/generic/applets/digital-clock/clock.h (4aec3fd)
plasma/generic/applets/digital-clock/clock.cpp (dd03692)

--===============1251406629740706895==-- --===============1829971137616281785== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1829971137616281785==--