This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434/

This review has been submitted with commit 8bd86323cdbd11ffafb71b6d8f4836d0d4339af3 by Lamarque V. Souza to branch KDE/4.8.

- Commit

On December 19th, 2011, 2:03 p.m., Lamarque Vieira Souza wrote:

Review request for kdelibs and Plasma.

By Lamarque Vieira Souza.

Updated Dec. 19, 2011, 2:03 p.m.

Description

The patch resets time format in digital clock plasmoid when the user changes the 24h configuration in active-settings.

The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering if I should add this change to kdelibs instead of kde-workspace to avoid duplicating code. Anyway, I wanted someone to review the code to see if there can be any side effect.

Testing

Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does not take effect. Other kcm modules (e.g. keyboard), call emitChange.

Bugs: 289094

Diffs

plasma/generic/applets/digital-clock/clock.h (4aec3fd)
plasma/generic/applets/digital-clock/clock.cpp (dd03692)

View Diff