[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make KGlobalSettings reread locale settings before
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-27 12:41:05
Message-ID: 20111227124105.8095.91837 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103469/#review9300
-----------------------------------------------------------
This review has been submitted with commit \
7bc79dbefc2f52f92657d87c13c73170a5313e40 by Lamarque V. Souza to branch \
KDE/4.8.
- Commit Hook
On Dec. 19, 2011, 10:15 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103469/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2011, 10:15 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> This is patch number 3 to fix bug #289094 (top bar time incorrectly \
> displays in 24 hour format). The other patches are against plasma-mobile \
> and kde-workspace (http://git.reviewboard.kde.org/r/103434), all three \
> patches must be applied to fix the bug. I think this is a much simpler \
> solution than the one I suggested in \
> http://git.reviewboard.kde.org/r/103434.
>
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
>
>
> Diffs
> -----
>
> kdecore/localization/klocale.h 3495431
> kdecore/localization/klocale.cpp 499bf11
> kdecore/localization/klocale_p.h 4ed8e3f
> kdeui/kernel/kglobalsettings.h cb8f7e2
> kdeui/kernel/kglobalsettings.cpp 819b314
>
> Diff: http://git.reviewboard.kde.org/r/103469/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103469/">http://git.reviewboard.kde.org/r/103469/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
7bc79dbefc2f52f92657d87c13c73170a5313e40 by Lamarque V. Souza to branch \
KDE/4.8.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 19th, 2011, 10:15 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is patch number 3 to fix bug #289094 (top bar time \
incorrectly displays in 24 hour format). The other patches are against \
plasma-mobile and kde-workspace (http://git.reviewboard.kde.org/r/103434), \
all three patches must be applied to fix the bug. I think this is a much \
simpler solution than the one I suggested in \
http://git.reviewboard.kde.org/r/103434.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289094">289094</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/localization/klocale.h <span style="color: \
grey">(3495431)</span></li>
<li>kdecore/localization/klocale.cpp <span style="color: \
grey">(499bf11)</span></li>
<li>kdecore/localization/klocale_p.h <span style="color: \
grey">(4ed8e3f)</span></li>
<li>kdeui/kernel/kglobalsettings.h <span style="color: \
grey">(cb8f7e2)</span></li>
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: \
grey">(819b314)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103469/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic