'Re: Review Request: Change activity by rolling the mouse wheel over'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Change activity by rolling the mouse wheel over
From:       "Simone Gaiarin" <simgunz () gmail ! com>
Date:       2011-12-26 22:46:20
Message-ID: 20111226224620.6294.89202 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103548/
-----------------------------------------------------------

(Updated Dec. 26, 2011, 10:46 p.m.)

Review request for Plasma and Aaron J. Seigo.

Description
-------

Rolling the mouse wheel over the showActivityManager change the current act=
ivity. In this way it's not necessary to open the activities menu, select t=
he activity and close the menu and the activity change is faster.

Diffs
-----

  plasma/desktop/applets/showActivityManager/showActivityManager.h f58fbb71=
a633f7f2ee3185650a9a7cbb083ec955 =

  plasma/desktop/applets/showActivityManager/showActivityManager.cpp e77df0=
d82c64562390fc922105cd3aea9af138a2 =

Diff: http://git.reviewboard.kde.org/r/103548/diff/diff

Testing
-------

The plasmoid works fine after the patch.

Thanks,

Simone Gaiarin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103548/">http://git.reviewboard.kde.org/r/103548/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Simone Gaiarin.</div>

<p style="color: grey;"><i>Updated Dec. 26, 2011, 10:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rolling the mouse wheel over the showActivityManager change the current \
activity. In this way it&#39;s not necessary to open the activities menu, select the \
activity and close the menu and the activity change is faster.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The plasmoid works fine after the patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/showActivityManager/showActivityManager.h <span \
style="color: grey">(f58fbb71a633f7f2ee3185650a9a7cbb083ec955)</span></li>

 <li>plasma/desktop/applets/showActivityManager/showActivityManager.cpp <span \
style="color: grey">(e77df0d82c64562390fc922105cd3aea9af138a2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103548/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 