'Review Request: Integrate Plasma Scripting Console with KWin scripting'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Integrate Plasma Scripting Console with KWin scripting
From:       Martin_Gräßlin <kde () martin-graesslin ! com>
Date:       2011-12-23 14:24:52
Message-ID: 20111223142452.14777.55589 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103518/
-----------------------------------------------------------

Review request for kwin and Plasma.

Description
-------

* KWin scripting becomes partly controllable through D-Bus
* Desktop Scripting Console can control KWin scripts. For that two new meth=
ods to PlasmaApp's D-Bus interface are added. If in KWin mode the script is=
 passed to KWin through D-Bus
* Plasma Desktop Runner gains new keyword "wm console" to start Desktop Scr=
ipting Console in KWin mode.

Diffs
-----

  kwin/scripting/scripting.h b0d00f9 =

  kwin/scripting/scripting.cpp 0a71849 =

  plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h 227748d =

  plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp 617bc69 =

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml e9b6482 =

  plasma/desktop/shell/interactiveconsole.h f94b997 =

  plasma/desktop/shell/interactiveconsole.cpp 6f2ff75 =

  plasma/desktop/shell/plasmaapp.h 3c7289c =

  plasma/desktop/shell/plasmaapp.cpp b630225 =

Diff: http://git.reviewboard.kde.org/r/103518/diff/diff

Testing
-------

Screenshots
-----------

Desktop Scripting console with KWin integration
  http://git.reviewboard.kde.org/r/103518/s/379/

Thanks,

Martin Gr=C3=A4=C3=9Flin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103518/">http://git.reviewboard.kde.org/r/103518/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* KWin scripting becomes partly controllable through \
                D-Bus
* Desktop Scripting Console can control KWin scripts. For that two new methods to \
PlasmaApp&#39;s D-Bus interface are added. If in KWin mode the script is passed to \
                KWin through D-Bus
* Plasma Desktop Runner gains new keyword &quot;wm console&quot; to start Desktop \
Scripting Console in KWin mode.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/scripting/scripting.h <span style="color: grey">(b0d00f9)</span></li>

 <li>kwin/scripting/scripting.cpp <span style="color: grey">(0a71849)</span></li>

 <li>plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.h <span \
style="color: grey">(227748d)</span></li>

 <li>plasma/desktop/runners/plasma-desktop/plasma-desktop-runner.cpp <span \
style="color: grey">(617bc69)</span></li>

 <li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(e9b6482)</span></li>

 <li>plasma/desktop/shell/interactiveconsole.h <span style="color: \
grey">(f94b997)</span></li>

 <li>plasma/desktop/shell/interactiveconsole.cpp <span style="color: \
grey">(6f2ff75)</span></li>

 <li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(3c7289c)</span></li>

 <li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(b630225)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103518/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/103518/s/379/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/23/wm-console_400x100.png" \
style="border: 1px black solid;" alt="Desktop Scripting console with KWin \
integration" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 