[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Make KGlobalSettings reread locale settings before
From: "Lamarque Vieira Souza" <lamarque () kde ! org>
Date: 2011-12-19 15:46:14
Message-ID: 20111219154614.17025.52768 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > kdeui/kernel/kglobalsettings.cpp, line 886
> > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867line886>
> >
> > I like the idea (KGlobalSettings reparsing configuration), but not the \
> > implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() \
> > (to reuse the KConfig naming) ?
KLocale::reparseConfiguration() would be just a call to KLocalePrivate::initFormat(), \
but initFormat is protected. I will have to make it public to use it in \
KLocale::reparseConfiguration, wouldn't that break binary compatibility? Another \
alternative is creating a public KLocalePrivate::reparseConfiguration() just to call \
KLocalePrivate::initFormat().
- Lamarque Vieira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103469/#review9078
-----------------------------------------------------------
On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103469/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2011, 2:02 p.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> This is patch number 3 to fix bug #289094 (top bar time incorrectly displays in 24 \
> hour format). The other patches are against plasma-mobile and kde-workspace \
> (http://git.reviewboard.kde.org/r/103434), all three patches must be applied to fix \
> the bug. I think this is a much simpler solution than the one I suggested in \
> http://git.reviewboard.kde.org/r/103434.
>
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
>
>
> Diffs
> -----
>
> kdeui/kernel/kglobalsettings.h cb8f7e2
> kdeui/kernel/kglobalsettings.cpp 819b314
>
> Diff: http://git.reviewboard.kde.org/r/103469/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lamarque Vieira Souza
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103469/">http://git.reviewboard.kde.org/r/103469/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 19th, 2011, 2:35 p.m., <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867line886" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdeui/kernel/kglobalsettings.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KGlobalSettings::Private::_k_slotNotifyChange(int changeType, int arg)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">886</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// Reread locale configuration files before signaling this \
process.</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I like the idea \
(KGlobalSettings reparsing configuration), but not the implementation \
(setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the \
KConfig naming) ?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KLocale::reparseConfiguration() would be just a call to \
KLocalePrivate::initFormat(), but initFormat is protected. I will have to make it \
public to use it in KLocale::reparseConfiguration, wouldn't that break binary \
compatibility? Another alternative is creating a public \
KLocalePrivate::reparseConfiguration() just to call \
KLocalePrivate::initFormat().</pre> <br />
<p>- Lamarque Vieira</p>
<br />
<p>On December 19th, 2011, 2:02 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 2:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is patch number 3 to fix bug #289094 (top bar time incorrectly \
displays in 24 hour format). The other patches are against plasma-mobile and \
kde-workspace (http://git.reviewboard.kde.org/r/103434), all three patches must be \
applied to fix the bug. I think this is a much simpler solution than the one I \
suggested in http://git.reviewboard.kde.org/r/103434.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289094">289094</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kglobalsettings.h <span style="color: grey">(cb8f7e2)</span></li>
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(819b314)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103469/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic