[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Activities Dataengine: avoid calling
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-17 19:19:39
Message-ID: 20111217191939.14736.56086 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103358/#review9027
-----------------------------------------------------------
This review has been submitted with commit 480db607b4ec63108e18738eb2dfa511=
69dcd865 by Luiz Rom=C3=A1rio Santana Rios to branch master.
- Commit Hook
On Dec. 16, 2011, 12:25 a.m., Rom=C3=A1rio Rios wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103358/
> -----------------------------------------------------------
> =
> (Updated Dec. 16, 2011, 12:25 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Avoid calling listActivities to get the list of running activities everyt=
ime by getting it once, storing it in a private member and modifying this m=
ember as activities come and go.
> =
> =
> Diffs
> -----
> =
> plasma/generic/dataengines/activities/activityengine.h cbbf94c =
> plasma/generic/dataengines/activities/activityengine.cpp 9436c34 =
> =
> Diff: http://git.reviewboard.kde.org/r/103358/diff/diff
> =
> =
> Testing
> -------
> =
> Tested it now, removed some activities, added some more, stopped another =
bunch, and it seems to work just fine as long as I tested.
> =
> =
> Thanks,
> =
> Rom=C3=A1rio Rios
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103358/">http://git.reviewboard.kde.org/r/103358/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 480db607b4ec63108e18738eb2dfa51169dcd865 by Luiz Romário \
Santana Rios to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 16th, 2011, 12:25 a.m., Romário Rios wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Romário Rios.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 12:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Avoid calling listActivities to get the list of running activities \
everytime by getting it once, storing it in a private member and modifying this \
member as activities come and go.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested it now, removed some activities, added some more, stopped another \
bunch, and it seems to work just fine as long as I tested.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/activities/activityengine.h <span style="color: \
grey">(cbbf94c)</span></li>
<li>plasma/generic/dataengines/activities/activityengine.cpp <span style="color: \
grey">(9436c34)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103358/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic