[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adding patch for checking url is remote or not
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-12-16 15:22:10
Message-ID: 20111216152210.2502.41198 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103393/#review9006
-----------------------------------------------------------
Ship it!
looks good except for one small issue (see below), but is generally ready t=
o go in. as this includes a new string, this needs to wait until 4.9 develo=
pment opens up (should happen early in january).
plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/103393/#comment7468>
just realized one more issue ... if the m_url is set twice in a row to =
a non-local file, then it will connect to this signal multiple times. this =
is easily controlled, however, by adding Qt::UniqueConnection to the parame=
ters passed to connect.
- Aaron J. Seigo
On Dec. 16, 2011, 6:20 a.m., Sujith Haridasan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103393/
> -----------------------------------------------------------
> =
> (Updated Dec. 16, 2011, 6:20 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Adding patch for the TODO, mentioned in the folderview.cpp file. This pat=
ch looks whether the url is local or remote. If its remote then checks for =
the network status of the host machine. If the host machine is not connecte=
d to the network then returns.
> =
> =
> Diffs
> -----
> =
> plasma/applets/folderview/folderview.h 4896f07 =
> plasma/applets/folderview/folderview.cpp 43d0511 =
> =
> Diff: http://git.reviewboard.kde.org/r/103393/diff/diff
> =
> =
> Testing
> -------
> =
> Tested by removing the host from the network and by adding the host to th=
e network.
> =
> =
> Thanks,
> =
> Sujith Haridasan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103393/">http://git.reviewboard.kde.org/r/103393/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good except for \
one small issue (see below), but is generally ready to go in. as this includes a new \
string, this needs to wait until 4.9 development opens up (should happen early in \
january).</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103393/diff/5/?file=43519#file43519line409" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/applets/folderview/folderview.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FolderView::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">408</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// \
the URL and waiting for the job to time out.</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">408</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">connect</span><span class="p">(</span><span class="n">Solid</span><span \
class="o">::</span><span class="n">Networking</span><span class="o">::</span><span \
class="n">notifier</span><span class="p">(),</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">shouldConnect</span><span class="p">()),</span> <span \
class="k">this</span><span class="p">,</span><span class="ew"> </span></pre></td> \
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">409</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">lister</span><span class="o">-></span><span \
class="n">openUrl</span><span class="p">(</span><span class="n">m_url</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">409</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">networkAvailable</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">just \
realized one more issue ... if the m_url is set twice in a row to a non-local file, \
then it will connect to this signal multiple times. this is easily controlled, \
however, by adding Qt::UniqueConnection to the parameters passed to connect.</pre> \
</div> <br />
<p>- Aaron J.</p>
<br />
<p>On December 16th, 2011, 6:20 a.m., Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 6:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding patch for the TODO, mentioned in the folderview.cpp file. This \
patch looks whether the url is local or remote. If its remote then checks for the \
network status of the host machine. If the host machine is not connected to the \
network then returns.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by removing the host from the network and by adding the host to \
the network.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(4896f07)</span></li>
<li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(43d0511)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103393/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic