[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Makes Notes applet remember the Notes color change
From: "Commit Hook" <null () kde ! org>
Date: 2011-12-08 9:34:27
Message-ID: 20111208093427.303.91894 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103353/#review8794
-----------------------------------------------------------
This review has been submitted with commit acb4d203d1d2e5ac3cad3be5bc2a13cddf4fc9d2 \
by Aaron Seigo to branch master.
- Commit Hook
On Dec. 7, 2011, 8:27 p.m., Anne-Marie Mahfouf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103353/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2011, 8:27 p.m.)
>
>
> Review request for Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> The Notes applet does not apply the Notes color change, nor by right click or via \
> the Settings dialog. The new color is not written in configuration. This was \
> because m_topWidget->color() always returns yellow-notes as a color. This patch \
> introduces a new variable to store the color without the -notes and match it \
> against the colors action menu.
> Manuel, can you test please?
>
>
> This addresses bugs 288286 and 288286.
> http://bugs.kde.org/show_bug.cgi?id=288286
> http://bugs.kde.org/show_bug.cgi?id=288286
>
>
> Diffs
> -----
>
> applets/notes/notes.h fde13cc
> applets/notes/notes.cpp 10a8753
>
> Diff: http://git.reviewboard.kde.org/r/103353/diff/diff
>
>
> Testing
> -------
>
> Tested and works as expected now, both on Desktop and dashboard.
>
> Tested by Manuel who reported 288286, works for him. Waiting for the thumb up about \
> the way it's fixed, maybe there's a cleaner way.
>
> Thanks,
>
> Anne-Marie Mahfouf
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103353/">http://git.reviewboard.kde.org/r/103353/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit acb4d203d1d2e5ac3cad3be5bc2a13cddf4fc9d2 by Aaron Seigo to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On December 7th, 2011, 8:27 p.m., Anne-Marie Mahfouf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Anne-Marie Mahfouf.</div>
<p style="color: grey;"><i>Updated Dec. 7, 2011, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The Notes applet does not apply the Notes color change, nor by right \
click or via the Settings dialog. The new color is not written in configuration. This \
was because m_topWidget->color() always returns yellow-notes as a color. This \
patch introduces a new variable to store the color without the -notes and match it \
against the colors action menu.
Manuel, can you test please?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested and works as expected now, both on Desktop and dashboard.
Tested by Manuel who reported 288286, works for him. Waiting for the thumb up about \
the way it's fixed, maybe there's a cleaner way.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288286">288286</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=288286">288286</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notes/notes.h <span style="color: grey">(fde13cc)</span></li>
<li>applets/notes/notes.cpp <span style="color: grey">(10a8753)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103353/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic