'Re: Review Request: Display media info on MediaPlayer applet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Display media info on MediaPlayer applet
From:       "Commit Hook" <null () kde ! org>
Date:       2011-12-03 15:34:12
Message-ID: 20111203153412.31142.56467 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103315/#review8686
-----------------------------------------------------------

This review has been submitted with commit 0a8be5c1f0b3bbd557ea85d08c5608e62f888fea \
by Vitor Boschi da Silva to branch mediaplayer-4.9.

- Commit Hook

On Dec. 3, 2011, 2:12 p.m., Vitor Boschi da Silva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103315/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2011, 2:12 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> Display the name of the playing media below the video using metadata or filename if \
> it's not available 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=270974.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270974
> 
> 
> Diffs
> -----
> 
> applets/mediaplayer/mediaplayer.h ab58cd2 
> applets/mediaplayer/mediaplayer.cpp d661abd 
> 
> Diff: http://git.reviewboard.kde.org/r/103315/diff/diff
> 
> 
> Testing
> -------
> 
> tried some music files and videos, with and without title metadata
> 
> 
> Thanks,
> 
> Vitor Boschi da Silva
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103315/">http://git.reviewboard.kde.org/r/103315/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0a8be5c1f0b3bbd557ea85d08c5608e62f888fea by Vitor Boschi da \
Silva to branch mediaplayer-4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 3rd, 2011, 2:12 p.m., Vitor Boschi da Silva wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Vitor Boschi da Silva.</div>

<p style="color: grey;"><i>Updated Dec. 3, 2011, 2:12 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Display the name of the playing media below the video using metadata or \
filename if it&#39;s not available</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tried some music files and videos, with and without title metadata</pre> \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270974">https://bugs.kde.org/show_bug.cgi?id=270974</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/mediaplayer/mediaplayer.h <span style="color: \
grey">(ab58cd2)</span></li>

 <li>applets/mediaplayer/mediaplayer.cpp <span style="color: \
grey">(d661abd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103315/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 