'Re: Review Request: Small improvement for the connman applet UI'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Small improvement for the connman applet UI
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2011-11-29 15:22:53
Message-ID: 20111129152253.1515.54968 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103079/#review8597
-----------------------------------------------------------

Ship it!

- Marco Martin

On Nov. 8, 2011, 4:37 p.m., Javier Llorente wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103079/
> -----------------------------------------------------------
> =

> (Updated Nov. 8, 2011, 4:37 p.m.)
> =

> =

> Review request for Plasma and Marco Martin.
> =

> =

> Description
> -------
> =

> Make WifiExpandingBox disconnect and apply buttons have the same width as=
 parent
> =

> =

> Diffs
> -----
> =

>   applets/org.kde.active.connman/contents/ui/WifiExpandingBox.qml d9be768=
06e7cb3be759774ce760875296d5fcc40 =

> =

> Diff: http://git.reviewboard.kde.org/r/103079/diff/diff
> =

> =

> Testing
> -------
> =

> Changes tested on a Wetab
> =

> =

> Thanks,
> =

> Javier Llorente
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103079/">http://git.reviewboard.kde.org/r/103079/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- Marco</p>

<br />
<p>On November 8th, 2011, 4:37 p.m., Javier Llorente wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Javier Llorente.</div>

<p style="color: grey;"><i>Updated Nov. 8, 2011, 4:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make WifiExpandingBox disconnect and apply buttons have the same width \
as parent</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changes tested on a Wetab</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/org.kde.active.connman/contents/ui/WifiExpandingBox.qml <span \
style="color: grey">(d9be76806e7cb3be759774ce760875296d5fcc40)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103079/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 