From kde-panel-devel Mon Nov 28 15:47:35 2011 From: "Aaron J. Seigo" Date: Mon, 28 Nov 2011 15:47:35 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:now StartPage::createNewProject() Message-Id: <20111128154735.27193.96136 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132249535300872 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7101286368043443004==" --===============7101286368043443004== Content-Type: multipart/alternative; boundary="===============0371709523895176813==" --===============0371709523895176813== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 28, 2011, 3:46 p.m., Aaron J. Seigo wrote: > > now that's a nice simplification :) one other note: please be sure that all the rest of the plasmate code that = assumes this directory structure (if any) is modified to work properly with= this new approach. - Aaron J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/#review8567 ----------------------------------------------------------- On Nov. 28, 2011, 2:52 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102732/ > ----------------------------------------------------------- > = > (Updated Nov. 28, 2011, 2:52 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Hello, > = > for the moment the .plasmateprojectrc file exists as a mark for the proje= cts created by plasmate. > We want the file to be created in the creation of the project not in the = load of the project,the patch does that. > = > cheers > = > = > Diffs > ----- > = > mainwindow.cpp 6ea7f0c = > startpage.h f16af4b = > startpage.cpp 75052b1 = > = > Diff: http://git.reviewboard.kde.org/r/102732/diff/diff > = > = > Testing > ------- > = > workinig > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============0371709523895176813== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102732/

On November 28th, 2011, 3:46 p.m., Aaron J.= Seigo wrote:
now that&=
#39;s a nice simplification :)

one other n=
ote: please be sure that all the rest of the plasmate code that assumes thi=
s directory structure (if any) is modified to work properly with this new a=
pproach.

- Aaron J.

On November 28th, 2011, 2:52 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated Nov. 28, 2011, 2:52 p.m.

Descripti= on

Hello,

for the moment the .plasmateprojectrc file exists as a mark for the project=
s created by plasmate.
We want the file to be created in the creation of the project not in the lo=
ad of the project,the patch does that.

cheers

Testing <= /h1>

workinig

Diffs=

mainwindow.cpp (6ea7f0c)
startpage.h (f16af4b)
startpage.cpp (75052b1)

View Diff

--===============0371709523895176813==-- --===============7101286368043443004== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7101286368043443004==--