[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Add mimetype support into the
From: "Antonis Tsiapaliokas" <kok3rs () gmail ! com>
Date: 2011-11-28 9:29:54
Message-ID: 20111128092954.25072.43237 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102357/
-----------------------------------------------------------
(Updated Nov. 28, 2011, 9:29 a.m.)
Review request for Plasma.
Changes
-------
Typo fixed. Also with my previous patch if you could try to add a new file to the \
plasmoid with an extension, for example main.py and the plasmoid had api="Ruby" then \
the name of the file was main.py.rb.
Description
-------
Hello
If you open the "files" toolbar and you try to add something new with the "New.." in \
the executable scripts, then if you don't add the .{qml,js,rb,py}, then the file will \
be saved without the mimetype extension. This patch is fixing this issue.If you don't \
like something into the names which i gave, then let me know :)
Diffs (updated)
-----
editors/editpage.h 7b5dca3
editors/editpage.cpp d4b0082
editors/metadata/metadataeditor.h e02d8e3
editors/metadata/metadataeditor.cpp 256e334
packagemodel.h a14033c
packagemodel.cpp 8c0907a
Diff: http://git.reviewboard.kde.org/r/102357/diff/diff
Testing
-------
plasmate compiles fine. New files can be added into the other menus, without any \
issue.
Thanks,
Antonis Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102357/">http://git.reviewboard.kde.org/r/102357/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2011, 9:29 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Typo fixed. Also with my previous patch if you could try to add a new \
file to the plasmoid with an extension, for example main.py and the plasmoid had \
api="Ruby" then the name of the file was main.py.rb.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello
If you open the "files" toolbar and you try to add something new with the \
"New.." in the executable scripts, then if you don't add the \
.{qml,js,rb,py}, then the file will be saved without the mimetype extension. This \
patch is fixing this issue.If you don't like something into the names which i \
gave, then let me know :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">plasmate compiles fine. New files can be added into the other menus, \
without any issue. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>editors/editpage.h <span style="color: grey">(7b5dca3)</span></li>
<li>editors/editpage.cpp <span style="color: grey">(d4b0082)</span></li>
<li>editors/metadata/metadataeditor.h <span style="color: \
grey">(e02d8e3)</span></li>
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(256e334)</span></li>
<li>packagemodel.h <span style="color: grey">(a14033c)</span></li>
<li>packagemodel.cpp <span style="color: grey">(8c0907a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102357/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic