'Re: Review Request: Fix Notes applet crash on load'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix Notes applet crash on load
From:       "Dario Freddi" <drf () kde ! org>
Date:       2011-11-26 0:35:51
Message-ID: 20111126003551.24592.83423 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Nov. 26, 2011, 12:34 a.m., Commit Hook wrote:
> > This review has been submitted with commit 787935b68661d178589ac5371b3c=
3c3905529705 by Dario Freddi to branch master.

I am really sorry, it was meant to be review 103233

- Dario

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103203/#review8472
-----------------------------------------------------------

On Nov. 22, 2011, 8:42 a.m., Ben Cooksley wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103203/
> -----------------------------------------------------------
> =

> (Updated Nov. 22, 2011, 8:42 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Fix a crash that always occurs with Plasma when trying to load the Notes =
applet.
> =

> =

> Diffs
> -----
> =

>   applets/notes/notes.cpp 4ce6c3a =

> =

> Diff: http://git.reviewboard.kde.org/r/103203/diff/diff
> =

> =

> Testing
> -------
> =

> Compiled, tried starting it with Plasmoid Viewer - no longer crashes.
> =

> =

> Thanks,
> =

> Ben Cooksley
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103203/">http://git.reviewboard.kde.org/r/103203/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 26th, 2011, 12:34 a.m., <b>Commit \
Hook</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
787935b68661d178589ac5371b3c3c3905529705 by Dario Freddi to branch master.</pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am really sorry, it \
was meant to be review 103233</pre> <br />

<p>- Dario</p>

<br />
<p>On November 22nd, 2011, 8:42 a.m., Ben Cooksley wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Ben Cooksley.</div>

<p style="color: grey;"><i>Updated Nov. 22, 2011, 8:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix a crash that always occurs with Plasma when trying to load the Notes \
applet.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, tried starting it with Plasmoid Viewer - no longer \
crashes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notes/notes.cpp <span style="color: grey">(4ce6c3a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103203/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 