'Re: Review Request: kdeplasma-addons:knowledgebase plasmoids will not'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: kdeplasma-addons:knowledgebase plasmoids will not
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-11-23 17:14:04
Message-ID: 20111123171404.4305.64209 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103220/#review8419
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On Nov. 23, 2011, 3:08 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103220/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> after this bug report bugs.gentoo.org/show_bug.cgi?id=391019 a patch has been made \
> for the CMakeLists.txt of the repository. 
> Here is the issue,
> knowledgebase depends on the ocs dataengine which(the ocs dataengine) will not be \
> installed if attica doesn't exist.But the knowledgebase will be installed and with \
> his dataengine missing the plasmoid will not get any data. 
> P.S.:the patch is not mine,i am just "pushing".The author of the patch is Andreas \
> K. Hüttel. 
> 
> Diffs
> -----
> 
> applets/CMakeLists.txt 4d066ed 
> 
> Diff: http://git.reviewboard.kde.org/r/103220/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103220/">http://git.reviewboard.kde.org/r/103220/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On November 23rd, 2011, 3:08 p.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2011, 3:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

after this bug report bugs.gentoo.org/show_bug.cgi?id=391019 a patch has been made \
for the CMakeLists.txt of the repository.

Here is the issue,
knowledgebase depends on the ocs dataengine which(the ocs dataengine) will not be \
installed if attica doesn&#39;t exist.But the knowledgebase will be installed and \
with his dataengine missing the plasmoid will not get any data.

P.S.:the patch is not mine,i am just &quot;pushing&quot;.The author of the patch is \
Andreas K. Hüttel.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/CMakeLists.txt <span style="color: grey">(4d066ed)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103220/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 