[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Ensure Plasma Desktop does not crash on exit with
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-22 10:11:49
Message-ID: 20111122101149.11186.59201 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > <http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71>
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* crash at a \
> > point) since you don't remove it - should be "takeFirst", yesno?
>
> Ben Cooksley wrote:
> Other code handles this for us - which is why qDeleteAll() crashes.
>
> Thomas Lübking wrote:
> sorry, but the only way i see this could be correct is that qlist (fun with \
> templates) subclasses pointer Types and reimplements delete to automatically remove \
> them from the list, what is, nicely spoken, sick. is there any detailed (official) \
> explanation on this?
see ContainmentPrivate::appletDestroyed(Plasma::Applet *applet) in \
kdelibs/plasma/containment.cpp
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
-----------------------------------------------------------
On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> -----------------------------------------------------------
>
> (Updated Nov. 22, 2011, 7:39 a.m.)
>
>
> Review request for kdelibs and Plasma.
>
>
> Description
> -------
>
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This patch \
> fixes one of those scenarios to ensure that Plasma Desktop does not crash on quit \
> or logout.
>
> Diffs
> -----
>
> plasma/private/containment_p.h 4025bf4
>
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
>
>
> Testing
> -------
>
> Compiled, Plasma Desktop no longer crashes on exit.
>
>
> Thanks,
>
> Ben Cooksley
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103202/">http://git.reviewboard.kde.org/r/103202/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 22nd, 2011, 9:24 a.m., <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103202/diff/1/?file=41732#file41732line71" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/private/containment_p.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">while</span> <span class="p">(</span><span class="o">!</span><span \
class="n">applets</span><span class="p">.</span><span class="n">isEmpty</span><span \
class="p">())</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ibeg your pardon? to me \
this looks like you delete the same entry forever (what *will* crash at a point) \
since you don't remove it - should be "takeFirst", yesno?</pre> \
</blockquote>
<p>On November 22nd, 2011, 9:27 a.m., <b>Ben Cooksley</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Other code handles this \
for us - which is why qDeleteAll() crashes.</pre> </blockquote>
<p>On November 22nd, 2011, 9:57 a.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry, but the only way \
i see this could be correct is that qlist (fun with templates) subclasses pointer \
Types and reimplements delete to automatically remove them from the list, what is, \
nicely spoken, sick. is there any detailed (official) explanation on this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">see \
ContainmentPrivate::appletDestroyed(Plasma::Applet *applet) in \
kdelibs/plasma/containment.cpp</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Plasma.</div>
<div>By Ben Cooksley.</div>
<p style="color: grey;"><i>Updated Nov. 22, 2011, 7:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. \
This patch fixes one of those scenarios to ensure that Plasma Desktop does not crash \
on quit or logout.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, Plasma Desktop no longer crashes on exit.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/private/containment_p.h <span style="color: grey">(4025bf4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103202/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic