From kde-panel-devel Tue Nov 22 09:57:32 2011 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Tue, 22 Nov 2011 09:57:32 +0000 To: kde-panel-devel Subject: Re: Review Request: Ensure Plasma Desktop does not crash on exit with Message-Id: <20111122095732.9795.90575 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132195596623384 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5858771900403657816==" --===============5858771900403657816== Content-Type: multipart/alternative; boundary="===============4047168869812217403==" --===============4047168869812217403== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 22, 2011, 9:24 a.m., Thomas L=C3=BCbking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will= * crash at a point) since you don't remove it - should be "takeFirst", yesn= o? > = > Ben Cooksley wrote: > Other code handles this for us - which is why qDeleteAll() crashes. sorry, but the only way i see this could be correct is that qlist (fun with= templates) subclasses pointer Types and reimplements delete to automatical= ly remove them from the list, what is, nicely spoken, sick. is there any detailed (official) explanation on this? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8384 ----------------------------------------------------------- On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103202/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2011, 7:39 a.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. Th= is patch fixes one of those scenarios to ensure that Plasma Desktop does no= t crash on quit or logout. > = > = > Diffs > ----- > = > plasma/private/containment_p.h 4025bf4 = > = > Diff: http://git.reviewboard.kde.org/r/103202/diff/diff > = > = > Testing > ------- > = > Compiled, Plasma Desktop no longer crashes on exit. > = > = > Thanks, > = > Ben Cooksley > = > --===============4047168869812217403== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103202/

On November 22nd, 2011, 9:24 a.m., Thomas L= =C3=BCbking wrote:
= = =
plasma/private/containment_p.h (Diff revision 1)
public:
71
        while (!applets.isEmpty()) {
ibeg your=
 pardon?
to me this looks like you delete the same entry forever (what *will* crash =
at a point) since you don't remove it - should be "takeFirst"=
, yesno?
On November 22nd, 2011, 9:27 a.m., Ben Cooksley wrote:
Other cod=
e handles this for us - which is why qDeleteAll() crashes.

sorry, but the only way i see this could be correct is that qlist (f=
un with templates) subclasses pointer Types and reimplements delete to auto=
matically remove them from the list, what is, nicely spoken, sick.
is there any detailed (official) explanation on this?

- Thomas

On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:

Review request for kdelibs and Plasma.

By Ben Cooksley.

Updated Nov. 22, 2011, 7:39 a.m.

Descripti= on

Qt 4.8 contains changes which break qDeleteAll() in certain =
scenarios. This patch fixes one of those scenarios to ensure that Plasma De=
sktop does not crash on quit or logout.

Testing <= /h1>

Compiled, Plasma Desktop no longer crashes on exit.

Diffs=

plasma/private/containment_p.h (4025bf4)

--===============4047168869812217403==-- --===============5858771900403657816== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5858771900403657816==--