This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/

On November 22nd, 2011, 9:24 a.m., Thomas Lübking wrote:

plasma/private/containment_p.h (Diff revision 1) 
public:
 

    71
    
        while (!applets.isEmpty()) {

  


 




  
ibeg your pardon?
to me this looks like you delete the same entry forever (what *will* crash at a point) since you don't remove it - should be "takeFirst", yesno?

 









Other code handles this for us - which is why qDeleteAll() crashes.








- Ben






On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:









 

  


Review request for kdelibs and Plasma.


By Ben Cooksley.




Updated Nov. 22, 2011, 7:39 a.m.








Description 

 

 

  
   
Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This patch fixes one of those scenarios to ensure that Plasma Desktop does not crash on quit or logout.

  		
 






Testing 



 

  
   
Compiled, Plasma Desktop no longer crashes on exit.

  		
 








Diffs 


    

 
  • plasma/private/containment_p.h (4025bf4)
    • 





View Diff