From kde-panel-devel Tue Nov 22 09:27:10 2011 From: "Ben Cooksley" Date: Tue, 22 Nov 2011 09:27:10 +0000 To: kde-panel-devel Subject: Re: Review Request: Ensure Plasma Desktop does not crash on exit with Message-Id: <20111122092710.5892.1717 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=132195413222709 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9091753174914870344==" --===============9091753174914870344== Content-Type: multipart/alternative; boundary="===============3520976746011373743==" --===============3520976746011373743== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 22, 2011, 9:24 a.m., Thomas L=C3=BCbking wrote: > > plasma/private/containment_p.h, line 71 > > > > > > ibeg your pardon? > > to me this looks like you delete the same entry forever (what *will= * crash at a point) since you don't remove it - should be "takeFirst", yesn= o? Other code handles this for us - which is why qDeleteAll() crashes. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103202/#review8384 ----------------------------------------------------------- On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103202/ > ----------------------------------------------------------- > = > (Updated Nov. 22, 2011, 7:39 a.m.) > = > = > Review request for kdelibs and Plasma. > = > = > Description > ------- > = > Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. Th= is patch fixes one of those scenarios to ensure that Plasma Desktop does no= t crash on quit or logout. > = > = > Diffs > ----- > = > plasma/private/containment_p.h 4025bf4 = > = > Diff: http://git.reviewboard.kde.org/r/103202/diff/diff > = > = > Testing > ------- > = > Compiled, Plasma Desktop no longer crashes on exit. > = > = > Thanks, > = > Ben Cooksley > = > --===============3520976746011373743== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103202/

On November 22nd, 2011, 9:24 a.m., Thomas L= =C3=BCbking wrote:

= = =
plasma/private/containment_p.h (Diff revision 1) 
public:
 

    71
    
        while (!applets.isEmpty()) {

  


 




  
ibeg your=
 pardon?
to me this looks like you delete the same entry forever (what *will* crash =
at a point) since you don't remove it - should be "takeFirst"=
, yesno?

 









Other code handles this for us - which is why qDeleteAll() crashes.<=
/pre>







- Ben






On November 22nd, 2011, 7:39 a.m., Ben Cooksley wrote:









 

  


Review request for kdelibs and Plasma.


By Ben Cooksley.




Updated Nov. 22, 2011, 7:39 a.m.








Descripti=
on 

 

 

  
   
Qt 4.8 contains changes which break qDeleteAll() in certain =
scenarios. This patch fixes one of those scenarios to ensure that Plasma De=
sktop does not crash on quit or logout.

  		
 






Testing <=
/h1>


 

  
   
Compiled, Plasma Desktop no longer crashes on exit.

  		
 








Diffs=
 


    

 
  • plasma/private/containment_p.h (4025bf4)
    • 





View Diff





  		
 











  

 



--===============3520976746011373743==--

--===============9091753174914870344==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

--===============9091753174914870344==--