'Review Request: Ensure Plasma Desktop does not crash on exit with Qt'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Ensure Plasma Desktop does not crash on exit with Qt
From:       "Ben Cooksley" <bcooksley () kde ! org>
Date:       2011-11-22 7:39:41
Message-ID: 20111122073941.28977.871 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/
-----------------------------------------------------------

Review request for kdelibs and Plasma.

Description
-------

Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This=
 patch fixes one of those scenarios to ensure that Plasma Desktop does not =
crash on quit or logout.

Diffs
-----

  plasma/private/containment_p.h 4025bf4 =

Diff: http://git.reviewboard.kde.org/r/103202/diff/diff

Testing
-------

Compiled, Plasma Desktop no longer crashes on exit.

Thanks,

Ben Cooksley

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103202/">http://git.reviewboard.kde.org/r/103202/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and Plasma.</div>
<div>By Ben Cooksley.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. \
This patch fixes one of those scenarios to ensure that Plasma Desktop does not crash \
on quit or logout.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, Plasma Desktop no longer crashes on exit.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/private/containment_p.h <span style="color: grey">(4025bf4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103202/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 