--===============7123365858650092900== Content-Type: multipart/alternative; boundary="===============6803258778624717465==" --===============6803258778624717465== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103088/#review8358 ----------------------------------------------------------- This review has been submitted with commit eee07eee672374616c9a5bea25a9d61d= a9846f0b by David E. Narv=C3=A1ez to branch KDE/4.7. - Commit Hook On Nov. 19, 2011, 5:42 p.m., David Narv=C3=A1ez wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103088/ > ----------------------------------------------------------- > = > (Updated Nov. 19, 2011, 5:42 p.m.) > = > = > Review request for Plasma and Christian Mollekopf. > = > = > Description > ------- > = > As the InvisibleCollectionFetch fetch strategy is currently broken, I imp= lemented a suggestion by Christian Mollekopf of working around the issues b= y flatting the model through a KDescendantsProxyModel to fix crashes in Pla= sma related to calendars. > = > = > This addresses bug 279322. > http://bugs.kde.org/show_bug.cgi?id=3D279322 > = > = > Diffs > ----- > = > plasma/generic/dataengines/calendar/calendarengine.cpp 53f98c0 = > = > Diff: http://git.reviewboard.kde.org/r/103088/diff/diff > = > = > Testing > ------- > = > 1. Add an iCal resource from the internet > 2. Refresh the iCal resource > 3. Refresh the iCal resource again if Plasma didn't crash on step 2 > = > Withouth this patch, Plasma crashes when trying to remove an item that ha= s no collection in the Calendar Model embedded in the Dataengine. > = > You should also be able to replicate bug 279322 without this patch and th= is patch should fix the situation described there. > = > = > Thanks, > = > David Narv=C3=A1ez > = > --===============6803258778624717465== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103088/

This revie=
w has been submitted with commit eee07eee672374616c9a5bea25a9d61da9846f0b b=
y David E. Narv=C3=A1ez to branch KDE/4.7.

- Commit

On November 19th, 2011, 5:42 p.m., David Narv=C3=A1ez wrote:

Review request for Plasma and Christian Mollekopf.

By David Narv=C3=A1ez.

Updated Nov. 19, 2011, 5:42 p.m.

Descripti= on

As the InvisibleCollectionFetch fetch strategy is currently =
broken, I implemented a suggestion by Christian Mollekopf of working around=
 the issues by flatting the model through a KDescendantsProxyModel to fix c=
rashes in Plasma related to calendars.

Testing <= /h1>

1. Add an iCal resource from the internet
2. Refresh the iCal resource
3. Refresh the iCal resource again if Plasma didn't crash on step 2

Withouth this patch, Plasma crashes when trying to remove an item that has =
no collection in the Calendar Model embedded in the Dataengine.

You should also be able to replicate bug 279322 without this patch and this=
 patch should fix the situation described there.

Bugs: 279322

Diffs=

plasma/generic/dataengines/calendar/calendarengine.cpp (53f98c0)

--===============6803258778624717465==-- --===============7123365858650092900== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7123365858650092900==--