This review has been submitted with commit eee07eee672374616c9a5bea25a9d61da9846f0b by David E. Narváez to branch KDE/4.7.
- Commit
On November 19th, 2011, 5:42 p.m., David Narváez wrote:
|
Review request for Plasma and Christian Mollekopf.
By David Narváez.
Updated Nov. 19, 2011, 5:42 p.m.
Description
As the InvisibleCollectionFetch fetch strategy is currently broken, I implemented a suggestion by Christian Mollekopf of working around the issues by flatting the model through a KDescendantsProxyModel to fix crashes in Plasma related to calendars.
|
Testing
1. Add an iCal resource from the internet
2. Refresh the iCal resource
3. Refresh the iCal resource again if Plasma didn't crash on step 2
Withouth this patch, Plasma crashes when trying to remove an item that has no collection in the Calendar Model embedded in the Dataengine.
You should also be able to replicate bug 279322 without this patch and this patch should fix the situation described there.
|
Diffs
- plasma/generic/dataengines/calendar/calendarengine.cpp (53f98c0)
View Diff
|